Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 497573004: Remove NOTREACHED() in ProxyConnectRedirectHttpStream::GetUploadProgress() (Closed)

Created:
6 years, 4 months ago by tyoshino (SeeGerritForStatus)
Modified:
6 years, 4 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Remove NOTREACHED() in ProxyConnectRedirectHttpStream::GetUploadProgress() We can hit this, and it seems removing this is fine. BUG=400968 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291439

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M net/http/proxy_connect_redirect_http_stream.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
tyoshino (SeeGerritForStatus)
6 years, 4 months ago (2014-08-22 04:15:10 UTC) #1
Ryan Hamilton
lgtm
6 years, 4 months ago (2014-08-22 04:36:18 UTC) #2
tyoshino (SeeGerritForStatus)
The CQ bit was checked by tyoshino@chromium.org
6 years, 4 months ago (2014-08-22 04:37:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/497573004/1
6 years, 4 months ago (2014-08-22 04:38:13 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 05:35:16 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 06:26:40 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/1305)
6 years, 4 months ago (2014-08-22 06:26:41 UTC) #7
tyoshino (SeeGerritForStatus)
The CQ bit was checked by tyoshino@chromium.org
6 years, 4 months ago (2014-08-22 16:29:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/497573004/1
6 years, 4 months ago (2014-08-22 16:30:26 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 17:26:00 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (1) as 291439

Powered by Google App Engine
This is Rietveld 408576698