chrome/browser/android/bookmarks/bookmarks_bridge.cc - Issue 497563002: [Android] Use correct enhanced bookmarks enabling logic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/bookmarks/bookmarks_bridge.cc

Issue 497563002: [Android] Use correct enhanced bookmarks enabling logic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: call UpdateBookmarksExperimentState on startup, JNI binding, etc.. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/about_flags.cc ('K') | « chrome/browser/about_flags.cc ('k') | chrome/browser/bookmarks/enhanced_bookmarks_features.h » ('j') | chrome/browser/bookmarks/enhanced_bookmarks_features.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/bookmarks/bookmarks_bridge.cc

diff --git a/chrome/browser/android/bookmarks/bookmarks_bridge.cc b/chrome/browser/android/bookmarks/bookmarks_bridge.cc

index 7cd704af9ffb109dc649c64c43aa1fe404c48c6a..53a7b27641373deb15d54fe8f786423bc4c358b7 100644

--- a/chrome/browser/android/bookmarks/bookmarks_bridge.cc

+++ b/chrome/browser/android/bookmarks/bookmarks_bridge.cc

@@ -9,6 +9,7 @@

#include "base/prefs/pref_service.h"

#include "chrome/browser/bookmarks/bookmark_model_factory.h"

#include "chrome/browser/bookmarks/chrome_bookmark_client_factory.h"

+#include "chrome/browser/bookmarks/enhanced_bookmarks_features.h"

#include "chrome/browser/profiles/incognito_helpers.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/profiles/profile_android.h"

@@ -108,6 +109,11 @@ static jboolean IsEditBookmarksEnabled(JNIEnv* env, jclass clazz) {

return IsEditBookmarksEnabled();

}

+static jboolean IsEnhancedBookmarksEnabled(JNIEnv* env, jclass clazz) {

+ return IsEnhancedBookmarksExperimentEnabled();

ScopedJavaLocalRef<jobject> BookmarksBridge::GetBookmarkByID(JNIEnv* env,

jobject obj,

jlong id,