Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: chrome/browser/about_flags.cc

Issue 497563002: [Android] Use correct enhanced bookmarks enabling logic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index dd4c1f9c9600da76e5626866c1da98918963d572..1f1220ecb7601d6cfa423d9661791005f43474e7 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -1625,7 +1625,7 @@ const Experiment kExperiments[] = {
"manual-enhanced-bookmarks",
IDS_FLAGS_ENABLE_ENHANCED_BOOKMARKS_NAME,
IDS_FLAGS_ENABLE_ENHANCED_BOOKMARKS_DESCRIPTION,
- kOsDesktop,
+ kOsDesktop | kOsAndroid,
SINGLE_VALUE_TYPE(switches::kManualEnhancedBookmarks)
},
{
@@ -2028,6 +2028,21 @@ bool SkipConditionalExperiment(const Experiment& experiment) {
return !IsEnhancedBookmarksExperimentEnabled();
}
+
+#if defined(OS_ANDROID)
+ // manual-enhanced-bookmarks is available for the Android internal channels.
+ // For other combinations, falls back to the default logic below.
+ if (experiment.internal_name == std::string("manual-enhanced-bookmarks")) {
+ switch (chrome::VersionInfo::GetChannel()) {
+ case chrome::VersionInfo::CHANNEL_UNKNOWN:
+ case chrome::VersionInfo::CHANNEL_CANARY:
+ case chrome::VersionInfo::CHANNEL_DEV:
Nico 2014/08/25 00:49:35 Flags shouldn't be channel-specific. See also the
+ return false;
+ default:
+ break;
+ }
+ }
+#endif
if ((experiment.internal_name == std::string("manual-enhanced-bookmarks")) ||
(experiment.internal_name ==
std::string("manual-enhanced-bookmarks-optout"))) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698