[Android] Use correct enhanced bookmarks enabling logic.

chrome/browser/bookmarks/enhanced_bookmarks_features.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_BOOKMARKS_ENHANCED_BOOKMARKS_FEATURES_H_
 #define CHROME_BROWSER_BOOKMARKS_ENHANCED_BOOKMARKS_FEATURES_H_
 
 #include <string>
 
 #include "extensions/common/extension.h"
@@ skipping 14 matching lines @@
   BOOKMARKS_EXPERIMENT_ENUM_SIZE
 };
 
 // Returns true and sets |extension_id| if bookmarks experiment enabled
 //         false if no bookmark experiment or extension id is empty.
 bool GetBookmarksExperimentExtensionID(const PrefService* user_prefs,
                                        std::string* extension_id);
 
 // Updates bookmark experiment state based on information from Chrome sync
 // and Finch experiments.
 void UpdateBookmarksExperimentState(

[Kibeom Kim (inactive), 2014/08/26 23:54:50]

Yaron: I think I need to call this on profile initialization and profile
changed. Do you know where would be the proper places to call?

[Yaron, 2014/08/27 00:09:59]

Why is this different from desktop versions?

[Yaron, 2014/08/27 00:12:13]

The reason I think it's ok is that Finch is per install (not user profile) so is
independent of it. If a new user signs in and gets the sync variant, it will
fire ExperimentEnabled when it downloads that update.

[Kibeom Kim (inactive), 2014/08/27 17:21:09]

I see, then I'll just call it once on initialization. (to read the opt-in flag)

     PrefService* user_prefs,
     PrefService* local_state,
     bool user_signed_in,
     BookmarksExperimentState experiment_enabled_from_sync);
 
 // Sets flag to opt-in user into Finch experiment.
 void ForceFinchBookmarkExperimentIfNeeded(
     PrefService* local_state,
     BookmarksExperimentState bookmarks_experiment_state);
 
+#if defined(OS_ANDROID)
+
+// Returns true if enhanced bookmark salient image prefetching is enabled.
+// This can be controlled by field trial.
+bool IsEnhancedBookmarkImageFetchingEnabled(const PrefService* user_prefs);
+
+// Returns true if enhanced bookmarks experiment is enabled.
+// Experiment could be enable from Chrome sync or from Finch.
+bool IsEnhancedBookmarksExperimentEnabled(const PrefService* user_prefs);
+
+#else
+
 // Returns true if enhanced bookmarks experiment is enabled.
 // Experiment could be enable from Chrome sync or from Finch.
 bool IsEnhancedBookmarksExperimentEnabled();
 
-#if defined(OS_ANDROID)
-bool IsEnhancedBookmarkImageFetchingEnabled();
 #endif
 
 // Returns true when flag enable-dom-distiller is set or enabled from Finch.
 bool IsEnableDomDistillerSet();
 
 // Returns true when flag enable-sync-articles is set or enabled from Finch.
 bool IsEnableSyncArticlesSet();
 
 #endif  // CHROME_BROWSER_BOOKMARKS_ENHANCED_BOOKMARKS_FEATURES_H_