Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Side by Side Diff: chrome/browser/bookmarks/enhanced_bookmarks_features.h

Issue 497563002: [Android] Use correct enhanced bookmarks enabling logic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: indent fix Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_BOOKMARKS_ENHANCED_BOOKMARKS_FEATURES_H_ 5 #ifndef CHROME_BROWSER_BOOKMARKS_ENHANCED_BOOKMARKS_FEATURES_H_
6 #define CHROME_BROWSER_BOOKMARKS_ENHANCED_BOOKMARKS_FEATURES_H_ 6 #define CHROME_BROWSER_BOOKMARKS_ENHANCED_BOOKMARKS_FEATURES_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "extensions/common/extension.h" 10 #include "extensions/common/extension.h"
(...skipping 25 matching lines...) Expand all
36 PrefService* user_prefs, 36 PrefService* user_prefs,
37 PrefService* local_state, 37 PrefService* local_state,
38 bool user_signed_in, 38 bool user_signed_in,
39 BookmarksExperimentState experiment_enabled_from_sync); 39 BookmarksExperimentState experiment_enabled_from_sync);
40 40
41 // Sets flag to opt-in user into Finch experiment. 41 // Sets flag to opt-in user into Finch experiment.
42 void ForceFinchBookmarkExperimentIfNeeded( 42 void ForceFinchBookmarkExperimentIfNeeded(
43 PrefService* local_state, 43 PrefService* local_state,
44 BookmarksExperimentState bookmarks_experiment_state); 44 BookmarksExperimentState bookmarks_experiment_state);
45 45
46 #if defined(OS_ANDROID)
47 // Returns true if enhanced bookmark salient image prefetching is enabled.
48 // This can be controlled by field trial.
49 bool IsEnhancedBookmarkImageFetchingEnabled(PrefService* user_prefs,
50 PrefService* local_state);
51
52 // Returns true if enhanced bookmarks experiment is enabled.
53 // Experiment could be enable from Chrome sync or from Finch.
54 bool IsEnhancedBookmarksExperimentEnabled(PrefService* user_prefs,
55 PrefService* local_state);
56
57 #else
58
46 // Returns true if enhanced bookmarks experiment is enabled. 59 // Returns true if enhanced bookmarks experiment is enabled.
47 // Experiment could be enable from Chrome sync or from Finch. 60 // Experiment could be enable from Chrome sync or from Finch.
48 bool IsEnhancedBookmarksExperimentEnabled(); 61 bool IsEnhancedBookmarksExperimentEnabled();
49 62
50 #if defined(OS_ANDROID)
51 bool IsEnhancedBookmarkImageFetchingEnabled();
52 #endif 63 #endif
53 64
54 // Returns true when flag enable-dom-distiller is set or enabled from Finch. 65 // Returns true when flag enable-dom-distiller is set or enabled from Finch.
55 bool IsEnableDomDistillerSet(); 66 bool IsEnableDomDistillerSet();
56 67
57 // Returns true when flag enable-sync-articles is set or enabled from Finch. 68 // Returns true when flag enable-sync-articles is set or enabled from Finch.
58 bool IsEnableSyncArticlesSet(); 69 bool IsEnableSyncArticlesSet();
59 70
60 #endif // CHROME_BROWSER_BOOKMARKS_ENHANCED_BOOKMARKS_FEATURES_H_ 71 #endif // CHROME_BROWSER_BOOKMARKS_ENHANCED_BOOKMARKS_FEATURES_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698