Add QUIC tests for chunked uploads where the FIN frame has no body data.

Add QUIC tests for chunked uploads where the FIN frame has no body data.

This is part of work to allow embedders to send a chunk when they do
not yet know whether it is the final chunk.

BUG=405678
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291282

[mmenke, 2014-08-21 20:52:36]

https://codereview.chromium.org/497553002/diff/2/net/quic/quic_http_stream_te...
File net/quic/quic_http_stream_test.cc (right):

https://codereview.chromium.org/497553002/diff/2/net/quic/quic_http_stream_te...
net/quic/quic_http_stream_test.cc:52: const char kUploadData[] = "Really nifty
data!";
Sending upload data of "hello world!" to get a response of "Hello world!" just
seems a recipe for confusion.

https://codereview.chromium.org/497553002/diff/2/net/quic/quic_http_stream_te...
net/quic/quic_http_stream_test.cc:602: ProcessPacket(ConstructAckPacket(1, 0,
0));
I really can't make sense of ConstructAckPacket's arguments, beyond the first. 
I'm just assuming this correct, regardless of whether the request, including the
body, is 1, 2, or 3 packets, because it seems to magically work.

[Ryan Hamilton, 2014-08-21 21:06:44]

lgtm

https://codereview.chromium.org/497553002/diff/2/net/quic/quic_http_stream_te...
File net/quic/quic_http_stream_test.cc (right):

https://codereview.chromium.org/497553002/diff/2/net/quic/quic_http_stream_te...
net/quic/quic_http_stream_test.cc:52: const char kUploadData[] = "Really nifty
data!";
On 2014/08/21 20:52:35, mmenke wrote:
> Sending upload data of "hello world!" to get a response of "Hello world!" just
> seems a recipe for confusion.

Good point.

https://codereview.chromium.org/497553002/diff/2/net/quic/quic_http_stream_te...
net/quic/quic_http_stream_test.cc:602: ProcessPacket(ConstructAckPacket(1, 0,
0));
On 2014/08/21 20:52:36, mmenke wrote:
> I really can't make sense of ConstructAckPacket's arguments, beyond the first.

> I'm just assuming this correct, regardless of whether the request, including
the
> body, is 1, 2, or 3 packets, because it seems to magically work.

The second argument should be the sequence number of the largest packet that the
peer has seen. Since the comment suggests all packets in the request, I would
expect it to be 2 in this case. Does that work?

(That being said, I see a number of other instances of 1, 0, 0 in this test, so
your current code is probably just fine)

[mmenke, 2014-08-21 21:20:48]

Thanks!

https://codereview.chromium.org/497553002/diff/2/net/quic/quic_http_stream_te...
File net/quic/quic_http_stream_test.cc (right):

https://codereview.chromium.org/497553002/diff/2/net/quic/quic_http_stream_te...
net/quic/quic_http_stream_test.cc:602: ProcessPacket(ConstructAckPacket(1, 0,
0));
On 2014/08/21 21:06:44, Ryan Hamilton wrote:
> On 2014/08/21 20:52:36, mmenke wrote:
> > I really can't make sense of ConstructAckPacket's arguments, beyond the
first.
> 
> > I'm just assuming this correct, regardless of whether the request, including
> the
> > body, is 1, 2, or 3 packets, because it seems to magically work.
> 
> The second argument should be the sequence number of the largest packet that
the
> peer has seen. Since the comment suggests all packets in the request, I would
> expect it to be 2 in this case. Does that work?
> 
> (That being said, I see a number of other instances of 1, 0, 0 in this test,
so
> your current code is probably just fine)

I tried that, but it results in a GMOCK warning, and an EXPECT failure.  I'll
just leave as-is.

[mmenke, 2014-08-21 21:22:00]

The CQ bit was checked by mmenke@chromium.org

[mmenke, 2014-08-21 21:22:11]

The CQ bit was unchecked by mmenke@chromium.org

[mmenke, 2014-08-21 21:22:55]

On 2014/08/21 21:22:11, mmenke wrote:
> The CQ bit was unchecked by mailto:mmenke@chromium.org

Actually, I'll remove those comments about what's being acked...since they're
false (They were copied from the other tests, where they're also apparently
false, but I'll leave those to wiser minds to worry about).

[mmenke, 2014-08-21 21:24:38]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2014-08-21 21:27:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mmenke@chromium.org/497553002/50001

[commit-bot: I haz the power, 2014-08-21 22:43:09]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[commit-bot: I haz the power, 2014-08-22 00:57:42]

Committed patchset #3 (50001) as 291282