 Chromium Code Reviews
 Chromium Code Reviews Issue 49753002:
  RAPPOR implementation  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 49753002:
  RAPPOR implementation  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: chrome/browser/prefs/pref_metrics_service.cc | 
| diff --git a/chrome/browser/prefs/pref_metrics_service.cc b/chrome/browser/prefs/pref_metrics_service.cc | 
| index 6bbfa4aa0a7e61e98e8097d4662c3c2a15046e41..28c0ea4f38044639f2824162b13e83502c7d15ed 100644 | 
| --- a/chrome/browser/prefs/pref_metrics_service.cc | 
| +++ b/chrome/browser/prefs/pref_metrics_service.cc | 
| @@ -28,6 +28,8 @@ | 
| #include "chrome/common/chrome_switches.h" | 
| #include "chrome/common/pref_names.h" | 
| #include "components/browser_context_keyed_service/browser_context_dependency_manager.h" | 
| +#include "components/rappor/rappor_service.h" | 
| +#include "components/rappor/rappor_utils.h" | 
| #include "crypto/hmac.h" | 
| #include "grit/browser_resources.h" | 
| #include "net/base/registry_controlled_domains/registry_controlled_domain.h" | 
| @@ -71,6 +73,15 @@ const char* kTrackedPrefs[] = { | 
| const size_t kSHA256DigestSize = 32; | 
| +const rappor::RapporParameters kHomePageRapporParameters = { | 
| + "Settings.HomePage", 16 /* Bloom filter size bytes */, | 
| + 4 /* Bloom filter hash count */, | 
| + rappor::PROBABILITY_75 /* Fake data probability */, | 
| + rappor::PROBABILITY_50 /* Fake one probability */, | 
| + rappor::PROBABILITY_75 /* One coin probability */, | 
| + rappor::PROBABILITY_50 /* Zero coin probability */ | 
| +}; | 
| + | 
| } // namespace | 
| PrefMetricsService::PrefMetricsService(Profile* profile) | 
| @@ -151,6 +162,10 @@ void PrefMetricsService::RecordLaunchPrefs() { | 
| "Settings.HomePageEngineType", | 
| TemplateURLPrepopulateData::GetEngineType(homepage_url), | 
| SEARCH_ENGINE_MAX); | 
| + std::vector<std::string> url_parts; | 
| + rappor::GetUrlParts(homepage_url, &url_parts); | 
| 
Alexei Svitkine (slow)
2014/01/09 19:23:09
I think the service should just have a RecordURL()
 
Steven Holte
2014/01/09 22:03:01
Done.
 | 
| + g_browser_process->rappor_service()->RecordSamples( | 
| + kHomePageRapporParameters, url_parts); | 
| } | 
| } |