Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5963)

Unified Diff: chrome/browser/prefs/pref_metrics_service.cc

Issue 49753002: RAPPOR implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/prefs/browser_prefs.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prefs/pref_metrics_service.cc
diff --git a/chrome/browser/prefs/pref_metrics_service.cc b/chrome/browser/prefs/pref_metrics_service.cc
index 8b6f389f961c1d5cf0a3c24a9865c05651e721a3..df7ae1034f175e4d633cf722d467c0049aff93be 100644
--- a/chrome/browser/prefs/pref_metrics_service.cc
+++ b/chrome/browser/prefs/pref_metrics_service.cc
@@ -22,6 +22,7 @@
#include "chrome/common/chrome_switches.h"
#include "chrome/common/pref_names.h"
#include "components/browser_context_keyed_service/browser_context_dependency_manager.h"
+#include "components/rappor/rappor_service.h"
#include "crypto/hmac.h"
#include "net/base/registry_controlled_domains/registry_controlled_domain.h"
@@ -70,7 +71,8 @@ void PrefMetricsService::RecordLaunchPrefs() {
// use, due to both false negatives (pages that come from unknown TLD+1 X but
// consist of a search box that sends to known TLD+1 Y) and false positives
// (pages that share a TLD+1 with a known engine but aren't actually search
- // pages, e.g. plus.google.com).
+ // pages, e.g. plus.google.com). Additionally, record the TLD+1 of non-NTP
+ // homepages through the privacy-preserving Rappor service.
if (!home_page_is_ntp) {
GURL homepage_url(prefs_->GetString(prefs::kHomePage));
if (homepage_url.is_valid()) {
@@ -78,6 +80,13 @@ void PrefMetricsService::RecordLaunchPrefs() {
"Settings.HomePageEngineType",
TemplateURLPrepopulateData::GetEngineType(homepage_url),
SEARCH_ENGINE_MAX);
+ if (g_browser_process->rappor_service()) {
+ g_browser_process->rappor_service()->RecordSample(
+ "Settings.HomePage",
+ rappor::ETLD_PLUS_ONE_RAPPOR_TYPE,
+ net::registry_controlled_domains::GetDomainAndRegistry(homepage_url,
+ net::registry_controlled_domains::INCLUDE_PRIVATE_REGISTRIES));
+ }
}
}
« no previous file with comments | « chrome/browser/prefs/browser_prefs.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698