RAPPOR implementation

components/rappor.gypi

Index: components/rappor.gypi
diff --git a/components/rappor.gypi b/components/rappor.gypi
new file mode 100644
index 0000000000000000000000000000000000000000..4a170edb1c34de3b49829060b20280b997f9b315
--- /dev/null
+++ b/components/rappor.gypi
@@ -0,0 +1,44 @@
+# Copyright 2014 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+{
+  'targets': [
+    {
+      'target_name': 'rappor',
+      'type': 'static_library',
+      'include_dirs': [
+        '..',
+      ],
+      'dependencies': [
+        '../base/base.gyp:base',
+        '../crypto/crypto.gyp:crypto',
+        '../net/net.gyp:net',
+        '../third_party/smhasher/smhasher.gyp:cityhash',
+        'variations',

[Ilya Sherman, 2014/02/13 01:39:03]

IMO it's not appropriate for the rappor component to depend on variations. 
Variations is about field trials; rappor has nothing to do with field trials
really (unless I'm missing something).  I know this doesn't feel like a big deal
right now, but getting this right at this time will make it easier to keep the
component layering healthy in the long term.

[Steven Holte, 2014/02/13 05:11:12]

No, it doesn't.  Unfortunately there a metrics component (yet) and it seems odd
to create one to put just MetricNameHash in it, and worse to leave it where it
was and depend on a chrome/ module.  The other alternative would be to move that
function to base/metrics/, which might be reasonable.

[Ilya Sherman, 2014/02/13 23:23:08]

We should move code out of //chrome/browser/metrics into //components/metrics
anyway: [ http://crbug.com/332475 ].  While it's a little silly to have a
component with just a single method in it, we'll need the component in the
long-run anyway, so I don't think there's any harm to creating it now.

[Steven Holte, 2014/02/14 02:53:28]

Done.  Though variations dependency is still required for field trial
parameters.

+      ],
+      'sources': [
+        'rappor/bloom_filter.cc',
+        'rappor/bloom_filter.h',
+        'rappor/byte_vector_utils.cc',
+        'rappor/byte_vector_utils.h',
+        'rappor/log_uploader.cc',
+        'rappor/log_uploader.h',
+        'rappor/proto/rappor_metric.proto',
+        'rappor/rappor_metric.cc',
+        'rappor/rappor_metric.h',
+        'rappor/rappor_parameters.cc',
+        'rappor/rappor_parameters.h',
+        'rappor/rappor_pref_names.cc',
+        'rappor/rappor_pref_names.h',
+        'rappor/rappor_service.cc',
+        'rappor/rappor_service.h',
+      ],
+      'variables': {
+        'proto_in_dir': 'rappor/proto',
+        'proto_out_dir': 'components/rappor/proto',
+      },
+      'includes': [ '../build/protoc.gypi' ],
+    },
+  ],
+}