chrome/browser/chrome_browser_main.cc - Issue 49753002: RAPPOR implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_browser_main.cc

Issue 49753002: RAPPOR implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Seperated log generation and uploading Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chrome_browser_main.cc

diff --git a/chrome/browser/chrome_browser_main.cc b/chrome/browser/chrome_browser_main.cc

index 36f411201d7135565472351f070dc5f8e5284f3e..c264e129592a9d3c4115d4161ea14f6207a16b53 100644

--- a/chrome/browser/chrome_browser_main.cc

+++ b/chrome/browser/chrome_browser_main.cc

@@ -115,6 +115,7 @@

#include "chrome/installer/util/google_update_settings.h"

#include "components/nacl/browser/nacl_browser.h"

#include "components/nacl/browser/nacl_process_host.h"

+#include "components/rappor/rappor_service.h"

#include "components/startup_metric_utils/startup_metric_utils.h"

#include "content/public/browser/browser_thread.h"

#include "content/public/browser/notification_observer.h"

@@ -1125,6 +1126,8 @@ int ChromeBrowserMainParts::PreMainMessageLoopRunImpl() {

#if !defined(OS_ANDROID)

// Now that the file thread has been started, start recording.

StartMetricsRecording();

+ rappor::g_rappor_service.Get().Start(browser_process_->local_state(),

+ browser_process_->system_request_context());

Alexei Svitkine (slow) 2013/12/11 15:27:05 Nit: Indent 2 more per C++ style.

Steven Holte 2013/12/11 20:31:26 Done.

#endif

// Create watchdog thread after creating all other threads because it will