components/rappor/rappor_pref_names.cc - Issue 49753002: RAPPOR implementation

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/rappor/rappor_pref_names.cc

Issue 49753002: RAPPOR implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "components/rappor/rappor_pref_names.h"

	6

	7 namespace rappor {

	8 namespace prefs {

	9

	10 // A base-64 encoded randomly generated byte string, which is used as a seed
	Ilya Sherman 2014/01/10 11:00:32 nit: "encoded randomly" -> "encoded, randomly" nit: "encoded randomly" -> "encoded, randomly" Steven Holte 2014/01/14 00:47:54 Done. Show quoted text On 2014/01/10 11:00:32, Ilya Sherman (Away Jan11-Feb2) wrote: > nit: "encoded randomly" -> "encoded, randomly" Done.
	11 // for generating fake data.
	Ilya Sherman 2014/01/10 11:00:32 nit: "for generating fake data" might be more easi nit: "for generating fake data" might be more easily understood by a casual reader as something like "for randomizing reported data", or perhaps a different word like "obfuscating", "obscuring", etc. in place of "randomizing". Steven Holte 2014/01/14 00:47:54 Changed to "redacting collected data". Show quoted text On 2014/01/10 11:00:32, Ilya Sherman (Away Jan11-Feb2) wrote: > nit: "for generating fake data" might be more easily understood by a casual > reader as something like "for randomizing reported data", or perhaps a different > word like "obfuscating", "obscuring", etc. in place of "randomizing". Changed to "redacting collected data".
	12 const char kRapporSecret[] = "rappor.secret";

	13

	14 } // namespace prefs

	15 } // namespace rappor

OLD	NEW

« components/rappor/rappor_parameters.h ('K') | « components/rappor/rappor_pref_names.h ('k') | components/rappor/rappor_service.h » ('j') | components/rappor/rappor_service.h » ('J')