RAPPOR implementation

components/rappor/rappor_metric_unittest.cc

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Test of RapporMetric class

[Ilya Sherman, 2014/01/10 11:00:32]

nit: No need for this comment IMO

[Steven Holte, 2014/01/14 00:47:54]

Done.

+#include "components/rappor/rappor_metric.h"
+
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace rappor {
+
+const RapporParameters kTestRapporParameters = {
+    "MyRappor", 16 /* Bloom filter size bytes */,
+    4 /* Bloom filter hash count */, PROBABILITY_75 /* Fake data probability */,

[Ilya Sherman, 2014/01/10 11:00:32]

Optional nit: Might be easier to read if written with one data member per line.

[Steven Holte, 2014/01/14 00:47:54]

Done.

[Steven Holte, 2014/01/14 00:47:54]

Done.

+    PROBABILITY_50 /* Fake one probability */,
+    PROBABILITY_75 /* One coin probability */,
+    PROBABILITY_50 /* Zero coin probability */
+};
+
+// Check for basic syntax and use.
+TEST(RapporMetricTest, BasicTest) {
+  RapporMetric testRappor(kTestRapporParameters);
+  testRappor.AddSample("Foo");
+  testRappor.AddSample("Bar");
+  EXPECT_EQ(0x20, testRappor.GetBytes()[1]);
+}
+
+TEST(RapporMetricTest, GetReportTest) {
+  RapporMetric rappor(kTestRapporParameters);
+
+  std::vector<uint8_t> report = rappor.GetReport("MySecret");
+  ASSERT_EQ(16u, report.size());
+}

[Ilya Sherman, 2014/01/10 11:00:32]

Again, statistical tests with many 9's of likelihood of success would be very
useful for a class like this.

[Steven Holte, 2014/01/15 23:00:57]

Done.

+
+}  // namespace rappor