RAPPOR implementation

components/rappor/bloom_filter_unittest.cc

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/rappor/bloom_filter.h"
+
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace rappor {
+
+TEST(BloomFilterTest, TestAddString) {
+  BloomFilter filter(2, 2);
+
+  ASSERT_EQ(2u, filter.bytes().size());
+  ASSERT_EQ(0u, filter.bytes()[0]);
+  ASSERT_EQ(0, filter.bytes()[1]);

[Ilya Sherman, 2014/01/10 11:00:32]

Why is line 15 unsigned and line 16 signed?

[Steven Holte, 2014/01/14 00:47:54]

Done.

+
+  filter.AddString("Foo");
+  ASSERT_EQ(2u, filter.bytes()[0]);
+  ASSERT_EQ(8u, filter.bytes()[1]);
+
+  filter.AddString("Bar");
+  ASSERT_EQ(3u, filter.bytes()[0]);
+  ASSERT_EQ(9u, filter.bytes()[1]);
+}
+
+TEST(BloomFilterTest, TestAddStrings) {
+  BloomFilter filter(2, 2);
+  std::vector<std::string> strs;
+  strs.push_back("Bar");
+  strs.push_back("Foo");
+  filter.AddStrings(strs);
+
+  ASSERT_EQ(2u, filter.bytes().size());
+  ASSERT_EQ(3u, filter.bytes()[0]);
+  ASSERT_EQ(9u, filter.bytes()[1]);

[Ilya Sherman, 2014/01/10 11:00:32]

nit: Please use EXPECT_EQ rather than ASSERT_EQ, throughout, except for the
size() assertions.  The Chromium style convention is to only use ASSERT_EQ in
order to prevent crashes.  (Honestly IMO it's a little silly that we bother to
distinguish, but it is the overwhelmingly prevailing style from what I've seen.)

[Steven Holte, 2014/01/14 00:47:54]

Done.

+}

[Ilya Sherman, 2014/01/10 11:00:32]

Please add some more testing of potential edge-cases, e.g. tiny Bloom filters,
huge Bloom filters, repeated insertion of a value, hash collisions, etc.

[Steven Holte, 2014/01/15 04:53:44]

Done.

+
+}  // namespace rappor