components/rappor/rappor_pref_names.cc - Issue 49753002: RAPPOR implementation

Side by Side Diff: components/rappor/rappor_pref_names.cc

Issue 49753002: RAPPOR implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "components/rappor/rappor_pref_names.h"

	6

	7 namespace rappor {

	8 namespace prefs {

	9

	10 // A base-64 encoded, randomly generated byte string, which is used as a seed

	11 // for redacting collected data.
	Ilya Sherman 2014/02/13 01:39:03 IMPORTANT: Historically with UMA, we have been ver IMPORTANT: Historically with UMA, we have been very cautious not to store anything that looks like a unique identifier on the local client, even if it is never transmitted via the network. Is this client secret equivalent to a unique identifier? If so, we should have a deep privacy discussion about this. Regardless of your answer above, please document the expected entropy of this client secret -- i.e., how many random bytes are in the string? Steven Holte 2014/02/13 05:11:12 Well this has at least 192 bits of entropy, should Show quoted text On 2014/02/13 01:39:03, Ilya Sherman wrote: > IMPORTANT: Historically with UMA, we have been very cautious not to store > anything that looks like a unique identifier on the local client, even if it is > never transmitted via the network. Is this client secret equivalent to a unique > identifier? If so, we should have a deep privacy discussion about this. > > Regardless of your answer above, please document the expected entropy of this > client secret -- i.e., how many random bytes are in the string? Well this has at least 192 bits of entropy, should probably have double that, and is randomly generated on the client, so it would definitely be unique. Not sure I understand the rational about not wanting to store such a value though. At that amount of entropy, documenting the amount of entropy seems a bit moot for your purposes. Ilya Sherman 2014/02/13 23:23:08 Started an email thread to discuss this. Show quoted text On 2014/02/13 05:11:12, Steven Holte wrote: > On 2014/02/13 01:39:03, Ilya Sherman wrote: > > IMPORTANT: Historically with UMA, we have been very cautious not to store > > anything that looks like a unique identifier on the local client, even if it > is > > never transmitted via the network. Is this client secret equivalent to a > unique > > identifier? If so, we should have a deep privacy discussion about this. > > > > Regardless of your answer above, please document the expected entropy of this > > client secret -- i.e., how many random bytes are in the string? > > Well this has at least 192 bits of entropy, should probably have double that, > and is randomly generated on the client, so it would definitely be unique. Not > sure I understand the rational about not wanting to store such a value though. > At that amount of entropy, documenting the amount of entropy seems a bit moot > for your purposes. Started an email thread to discuss this.
	12 // Important: This value should remain secret at the client, and never be

	13 // reported on the network, or to the server.

	14 const char kRapporSecret[] = "rappor.secret";

	15

	16 // A randomly generated number, which determines cohort data is reported for.
	Ilya Sherman 2014/02/13 01:39:03 Essentially the same comment as above applies here Essentially the same comment as above applies here.
	17 const char kRapporCohort[] = "rappor.cohort";

	18

	19 } // namespace prefs

	20 } // namespace rappor

OLD	NEW

« components/rappor/rappor_pref_names.h ('K') | « components/rappor/rappor_pref_names.h ('k') | components/rappor/rappor_service.h » ('j') | components/rappor/rappor_service.h » ('J')