components/rappor/rappor_pref_names.h - Issue 49753002: RAPPOR implementation

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/rappor/rappor_pref_names.h

Issue 49753002: RAPPOR implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef COMPONENTS_RAPPOR_RAPPOR_PREF_NAMES_H_

	6 #define COMPONENTS_RAPPOR_RAPPOR_PREF_NAMES_H_

	7

	8 namespace rappor {

	9 namespace prefs {

	10

	11 // Alphabetical list of preference names specific to the Rappor

	12 // component. Keep alphabetized, and document each in the .cc file.

	13 extern const char kRapporSecret[];
	Alexei Svitkine (slow) 2013/12/19 19:47:02 I'm not sure there's precedent for having prefs in I'm not sure there's precedent for having prefs inside components. If there isn't, these can still be in chrome/ and passed as parameters to the ctor of the RapporService. Steven Holte 2013/12/20 03:03:55 See ./autofill/core/common/autofill_pref_names.h a Show quoted text On 2013/12/19 19:47:02, Alexei Svitkine wrote: > I'm not sure there's precedent for having prefs inside components. > > If there isn't, these can still be in chrome/ and passed as parameters to the > ctor of the RapporService. See ./autofill/core/common/autofill_pref_names.h and ./policy/core/common/policy_pref_names.h. It seems like a pretty reasonable convention.
	14

	15 } // namespace prefs

	16 } // namespace rappor

	17

	18 #endif // COMPONENTS_RAPPOR_RAPPOR_PREF_NAMES_H_

OLD	NEW