RAPPOR implementation

components/rappor/bloom_filter.h

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_RAPPOR_BLOOM_FILTER_H_
+#define COMPONENTS_RAPPOR_BLOOM_FILTER_H_
+
+#include <stdint.h>
+
+#include <string>
+#include <vector>
+
+#include "components/rappor/bytevector.h"
+
+namespace rappor {
+
+// BloomFilter is a simple bloom filter for keeping track of a set of strings.
+class BloomFilter {
+ public:
+  BloomFilter(uint32_t bytes_size, uint32_t hash_count);

[Alexei Svitkine (slow), 2013/12/19 19:47:02]

Nit: Add explicit ~BloomFilter() declaration here and empty implementation in
the .cc file.

[Steven Holte, 2013/12/20 03:03:55]

Done.

+  void AddString(const std::string& str);
+  void AddStrings(const std::vector<std::string>& strings);
+
+  // Returns the current value of the bloom filter's bit array.
+  const ByteVector& bytes() const;
+  // Returns the number of bits set for each string added to the filter.
+  uint32_t hash_count() const;
+
+ private:
+  // Stores the bit array of the bloom filter.
+  ByteVector bytes_;
+  // The number of bits to set for each string added.
+  uint32_t hash_count_;
+};

[Alexei Svitkine (slow), 2013/12/19 19:47:02]

Nit: DISALLOW_COPY_AND_ASSIGN(BloomFilter);

[Steven Holte, 2013/12/20 03:03:55]

Done.

+
+}  // namespace rappor
+
+#endif  // COMPONENTS_RAPPOR_BLOOM_FILTER_H_