components/rappor/rappor_reporter_unittest.cc - Issue 49753002: RAPPOR implementation

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/rappor/rappor_reporter_unittest.cc

Issue 49753002: RAPPOR implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "components/rappor/rappor_reporter.h"

	6 #include "components/rappor/rappor.h"

	7

	8 #include "testing/gtest/include/gtest/gtest.h"

	9

	10 namespace rappor {

	11

	12 TEST(RapporReporterTest, TestReporter) {

	13 RapporReporter reporter("MySecret");

	14 Rappor rappor("MyRappor", 16, 4, 4, 2, 4, 2);

	15

	16 std::vector<uint8_t> report = reporter.GetReport(rappor);

	17 ASSERT_EQ(16u, report.size());
	jwd 2013/12/17 23:00:25 Can the reporter be turned deterministic so that i Can the reporter be turned deterministic so that it can be more deeply tested? Steven Holte 2013/12/18 02:06:12 I'm not sure that making it deterministic adds any Show quoted text On 2013/12/17 23:00:25, Jesse Doherty wrote: > Can the reporter be turned deterministic so that it can be more deeply tested? I'm not sure that making it deterministic adds any meaningful additional coverage. We'd just be testing that our deterministic generator was deterministic.
	18 }

	19

	20 } // namespace rappor

OLD	NEW