RAPPOR implementation

components/rappor/rappor_recorder.cc

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/rappor/rappor_recorder.h"
+
+#include "base/at_exit.h"
+#include "base/debug/leak_annotations.h"
+#include "base/logging.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/synchronization/lock.h"
+#include "components/rappor/rappor.h"
+
+namespace rappor {
+
+// Initialize rappor gathering system.
+base::LazyInstance<RapporRecorder>::Leaky g_rappor_recorder =
+    LAZY_INSTANCE_INITIALIZER;
+
+void RapporRecorder::ClearRappors() {
+  base::AutoLock auto_lock(lock_);
+
+  for (RapporMap::iterator it = rappors_.begin(); rappors_.end() != it; ++it) {
+    delete it->second;
+  }
+  rappors_.clear();
+}
+
+void RapporRecorder::GetRappors(Rappors* output) {
+  base::AutoLock auto_lock(lock_);
+
+  for (RapporMap::iterator it = rappors_.begin(); rappors_.end() != it; ++it) {
+    DCHECK_EQ(it->first, it->second->rappor_name());
+    output->push_back(it->second);
+  }
+}
+
+Rappor* RapporRecorder::GetRappor(const std::string& name) {
+  base::AutoLock auto_lock(lock_);
+
+  RapporMap::iterator it = rappors_.find(name);
+  if (rappors_.end() != it)
+    return it->second;
+
+  Rappor* new_rappor = new Rappor(name, 16, 4, 4, 2, 4, 2);

[jwd, 2013/12/17 23:00:25]

This looks like voodoo. Can these constants be pulled out?

[Steven Holte, 2013/12/18 02:06:12]

Extracted the parameters into a RapporParameters object, which can be statically
initialized for each metric, and passed in here.

+
+  rappors_[name] = new_rappor;
+  return new_rappor;
+}
+
+RapporRecorder::RapporRecorder() {}
+
+RapporRecorder::~RapporRecorder() { ClearRappors(); }
+
+}  // namespace rappor