RAPPOR implementation

components/rappor/bloom_filter.cc

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/rappor/bloom_filter.h"
+
+#include "base/logging.h"
+#include "third_party/smhasher/src/City.h"
+
+namespace rappor {
+
+BloomFilter::BloomFilter(uint32_t bytes_size,
+                         uint32_t hash_function_count,
+                         uint32_t hash_seed_offset)
+    : bytes_(bytes_size),
+      hash_function_count_(hash_function_count),
+      hash_seed_offset_(hash_seed_offset) {
+  DCHECK_GT(bytes_size, 0u);
+}
+
+BloomFilter::~BloomFilter() {}
+
+void BloomFilter::AddString(const std::string& str) {
+  for (size_t i = 0; i < hash_function_count_; ++i) {
+    uint32_t index =
+        CityHash64WithSeed(str.data(), str.size(), hash_seed_offset_ + i);
+    uint32_t byte_index = (index / 8) % bytes_.size();

[ulfar, 2014/02/07 20:19:02]

I presume Chromium is full of assumptions about bytes being 8 bits, but it's
still funny to see this constant here.

Edit: Actually, since ByteVector is defined on uint8_t, this should always be
fine.  However, perhaps deserves a comment explaining why it is fine (or a
change in the type name of ByteVector).

[Steven Holte, 2014/02/07 21:08:16]

Added Comment

+    uint32_t bit_index = index % 8;
+    bytes_[byte_index] |= 1 << bit_index;
+  }
+}
+
+}  // namespace rappor