components/rappor/rappor_registry.h - Issue 49753002: RAPPOR implementation

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/rappor/rappor_registry.h

Issue 49753002: RAPPOR implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rappor Registry Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef COMPONENTS_RAPPOR_RAPPOR_REGISTRY_H_

	6 #define COMPONENTS_RAPPOR_RAPPOR_REGISTRY_H_

	7

	8 namespace rappor {

	9

	10 struct RapporParameters;

	11

	12 enum RapporRegistryIndex {

	13 HOME_PAGE_RAPPOR = 0,

	14 NUM_RAPPOR_REGISTRY_ENTRIES

	15 };

	16

	17 extern const RapporParameters g_rappor_registry[];
	Alexei Svitkine (slow) 2014/02/04 19:20:12 Can you expose a function rather than the array di Can you expose a function rather than the array directly? e.g. const RapporParameters& GetRapporParameters(RapporRegistryIndex index); The array can live entirely in the .cc file in the anon namespace. Steven Holte 2014/02/04 21:41:21 Moved this to rappor_service.cc as kRapporParamete Show quoted text On 2014/02/04 19:20:12, Alexei Svitkine wrote: > Can you expose a function rather than the array directly? > > e.g. > > const RapporParameters& GetRapporParameters(RapporRegistryIndex index); > > The array can live entirely in the .cc file in the anon namespace. Moved this to rappor_service.cc as kRapporParametersForType
	18

	19 } // namespace rappor

	20

	21 #endif // COMPONENTS_RAPPOR_RAPPOR_REGISTRY_H_

OLD	NEW