RAPPOR implementation

chrome/browser/prefs/pref_metrics_service.cc

-// Copyright 2013 The Chromium Authors. All rights reserved.
+// Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/prefs/pref_metrics_service.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/metrics/histogram.h"
 #include "base/prefs/pref_registry_simple.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/string_number_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/browser_shutdown.h"
 #include "chrome/browser/prefs/pref_service_syncable.h"
 #include "chrome/browser/prefs/session_startup_pref.h"
 #include "chrome/browser/prefs/synced_pref_change_registrar.h"
 #include "chrome/browser/profiles/incognito_helpers.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/search_engines/template_url_prepopulate_data.h"
 #include "chrome/browser/ui/tabs/pinned_tab_codec.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/pref_names.h"
 #include "components/browser_context_keyed_service/browser_context_dependency_manager.h"
+#include "components/rappor/rappor_service.h"
 #include "crypto/hmac.h"
 #include "net/base/registry_controlled_domains/registry_controlled_domain.h"
 
 namespace {
 
 const int kSessionStartupPrefValueMax = SessionStartupPref::kPrefValueMax;
 
+const rappor::RapporParameters kHomePageRapporParameters = {

[Alexei Svitkine (slow), 2014/02/03 22:34:18]

As I said in a previous comment, I don't think we should expose the API such
that any possible parameters can be passed in.

Instead, I suggest making a set of "known-good" parameters inside rappor/ and an
enum that lists them and make the API take the enum to refer to a given
parameter config.

This way, only known good parameters (reviewed by OWNERS of rappor/) can be
used, rather than the current state where someone could pass in values that may
defeat the goals of RAPPOR.

[Steven Holte, 2014/02/03 23:58:06]

Done.  These parameters now live in components/rappor/rappor_registry.cc

+    "Settings.HomePage" /* Metric name */,
+    16 /* Bloom filter size bytes */,
+    2 /* Bloom filter hash count */,
+    rappor::PROBABILITY_75 /* Fake data probability */,
+    rappor::PROBABILITY_50 /* Fake one probability */,
+    rappor::PROBABILITY_75 /* One coin probability */,
+    rappor::PROBABILITY_50 /* Zero coin probability */
+};
+
 }  // namespace
 
 PrefMetricsService::PrefMetricsService(Profile* profile)
     : profile_(profile),
       prefs_(profile_->GetPrefs()),
       local_state_(g_browser_process->local_state()),
       weak_factory_(this) {
   RecordLaunchPrefs();
 
   PrefServiceSyncable* prefs = PrefServiceSyncable::FromProfile(profile_);
@@ skipping 29 matching lines @@
   // consist of a search box that sends to known TLD+1 Y) and false positives
   // (pages that share a TLD+1 with a known engine but aren't actually search
   // pages, e.g. plus.google.com).
   if (!home_page_is_ntp) {
     GURL homepage_url(prefs_->GetString(prefs::kHomePage));
     if (homepage_url.is_valid()) {
       UMA_HISTOGRAM_ENUMERATION(
           "Settings.HomePageEngineType",
           TemplateURLPrepopulateData::GetEngineType(homepage_url),
           SEARCH_ENGINE_MAX);
+      g_browser_process->rappor_service()->RecordSample(
+          kHomePageRapporParameters,
+          net::registry_controlled_domains::GetDomainAndRegistry(homepage_url,
+              net::registry_controlled_domains::INCLUDE_PRIVATE_REGISTRIES));
     }
   }
 
   int restore_on_startup = prefs_->GetInteger(prefs::kRestoreOnStartup);
   UMA_HISTOGRAM_ENUMERATION("Settings.StartupPageLoadSettings",
                             restore_on_startup, kSessionStartupPrefValueMax);
   if (restore_on_startup == SessionStartupPref::kPrefValueURLs) {
     const base::ListValue* url_list =
         prefs_->GetList(prefs::kURLsToRestoreOnStartup);
     UMA_HISTOGRAM_CUSTOM_COUNTS("Settings.StartupPageLoadURLs",
@@ skipping 124 matching lines @@
 }
 
 bool PrefMetricsService::Factory::ServiceIsNULLWhileTesting() const {
   return false;
 }
 
 content::BrowserContext* PrefMetricsService::Factory::GetBrowserContextToUse(
     content::BrowserContext* context) const {
   return chrome::GetBrowserContextRedirectedInIncognito(context);
 }