chrome/common/metrics/proto/system_profile.proto - Issue 49753002: RAPPOR implementation

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/metrics/proto/system_profile.proto

Issue 49753002: RAPPOR implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/metrics/metrics_service.cc ('K') | « chrome/chrome_tests_unit.gypi ('k') | chrome/common/pref_names.h » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4 //	4 //

5 // Stores information about the user's brower and system configuration.	5 // Stores information about the user's brower and system configuration.

6 // The system configuration fields are recorded once per client session.	6 // The system configuration fields are recorded once per client session.

7	7

8 syntax = "proto2";	8 syntax = "proto2";

9	9

10 option optimize_for = LITE_RUNTIME;	10 option optimize_for = LITE_RUNTIME;

(...skipping 424 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
435 // The user's group within the field trial, as a 32-bit identifier.	435 // The user's group within the field trial, as a 32-bit identifier.

436 // Currently, the identifier is a hash of the group's name.	436 // Currently, the identifier is a hash of the group's name.

437 optional fixed32 group_id = 2;	437 optional fixed32 group_id = 2;

438 }	438 }

439 repeated FieldTrial field_trial = 9;	439 repeated FieldTrial field_trial = 9;

440	440

441 // Number of users currently signed into a multiprofile session.	441 // Number of users currently signed into a multiprofile session.

442 // A zero value indicates that the user count changed while the log is open.	442 // A zero value indicates that the user count changed while the log is open.

443 // Logged only on ChromeOS.	443 // Logged only on ChromeOS.

444 optional uint32 multi_profile_user_count = 17;	444 optional uint32 multi_profile_user_count = 17;

	445
	Steven Holte 2013/10/28 21:02:44 This probably should move somewhere else and be a This probably should move somewhere else and be a repeated message containing a name_hash. Does moving it directly to ChromeUserMetricsExtension seem like the right place? Ilya Sherman 2013/10/29 00:32:31 If this is meant to be a general utility for parti Show quoted text On 2013/10/28 21:02:44, holte wrote: > This probably should move somewhere else and be a repeated message containing a > name_hash. Does moving it directly to ChromeUserMetricsExtension seem like the > right place? If this is meant to be a general utility for particularly privacy-sensitive histograms in a privacy-respectful way, then yes, moving it directly to ChromeUserMetricsExtension seems like the right place. OTOH, if this is intended for reporting some specific system state outside of a histogram context, then it is probably more appropriate to keep it in this file, but to assign the field a more descriptive name.
	446 optional string bloom_filter_bits = 18;

445 }	447 }

OLD	NEW