Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 497523002: linux: Explicitly call FcInit() in ToolkitInitialized(). (Closed)

Created:
6 years, 4 months ago by Daniel Erat
Modified:
6 years, 4 months ago
Reviewers:
behdad_google, sky
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

linux: Explicitly call FcInit() in ToolkitInitialized(). This hopefully prevents implicit Fontconfig initialization from occurring later when queries are first made from gfx::FontRenderParams/Skia/Blink/etc. BUG=404311 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291298

Patch Set 1 #

Patch Set 2 : call base class implementation #

Patch Set 3 : FontConfig -> Fontconfig #

Total comments: 2

Patch Set 4 : fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M chrome/browser/chrome_browser_main_linux.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chrome_browser_main_linux.cc View 1 2 3 2 chunks +11 lines, -0 lines 0 comments Download
M ui/gfx/font_render_params_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Daniel Erat
6 years, 4 months ago (2014-08-21 17:31:15 UTC) #1
sky
LGTM https://codereview.chromium.org/497523002/diff/40001/chrome/browser/chrome_browser_main_linux.cc File chrome/browser/chrome_browser_main_linux.cc (right): https://codereview.chromium.org/497523002/diff/40001/chrome/browser/chrome_browser_main_linux.cc#newcode29 chrome/browser/chrome_browser_main_linux.cc:29: // implicit initialization in respons to threads' first ...
6 years, 4 months ago (2014-08-21 17:38:20 UTC) #2
behdad_google
lgtm
6 years, 4 months ago (2014-08-21 17:43:37 UTC) #3
Daniel Erat
https://codereview.chromium.org/497523002/diff/40001/chrome/browser/chrome_browser_main_linux.cc File chrome/browser/chrome_browser_main_linux.cc (right): https://codereview.chromium.org/497523002/diff/40001/chrome/browser/chrome_browser_main_linux.cc#newcode29 chrome/browser/chrome_browser_main_linux.cc:29: // implicit initialization in respons to threads' first calls ...
6 years, 4 months ago (2014-08-21 17:56:12 UTC) #4
Daniel Erat
I've confirmed under gdb that FcInit() is getting called first by ToolkitInitialized() with this change.
6 years, 4 months ago (2014-08-21 22:07:51 UTC) #5
Daniel Erat
The CQ bit was checked by derat@chromium.org
6 years, 4 months ago (2014-08-21 22:07:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/497523002/60001
6 years, 4 months ago (2014-08-21 22:12:31 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-21 23:21:08 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 01:28:57 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 (60001) as 291298

Powered by Google App Engine
This is Rietveld 408576698