Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 497493004: cc: Stop testing occlusion by making awkward queries. (Closed)

Created:
6 years, 4 months ago by danakj
Modified:
6 years, 3 months ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, piman
Project:
chromium
Visibility:
Public.

Description

cc: Stop testing occlusion by making awkward queries. We used to test the state of the occlusion tracker by making queries for various input rects to try and guess what its occlusion state must be. This is bad. Instead, we can query the state directly. This removes all state queries from tests that are verifying the occlusion tracker's internal state changes correctly. And adds some new tests that just set internal state and verify the query methods work correctly. R=enne Committed: https://crrev.com/f080b5b78fd221901d34f179100bdf0e6827aa31 Cr-Commit-Position: refs/heads/master@{#291608}

Patch Set 1 #

Patch Set 2 : unoccluded: . #

Patch Set 3 : unoccluded: replicaqueries #

Unified diffs Side-by-side diffs Delta from patch set Stats (+421 lines, -505 lines) Patch
M cc/test/test_occlusion_tracker.h View 1 chunk +15 lines, -0 lines 0 comments Download
M cc/trees/occlusion_tracker_unittest.cc View 1 2 22 chunks +406 lines, -505 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
danakj
A long-standing self-wish!
6 years, 4 months ago (2014-08-22 01:31:44 UTC) #1
enne (OOO)
lgtm!!
6 years, 4 months ago (2014-08-22 20:15:26 UTC) #2
danakj
The concept of checking the replica's occlusion was now only a concept in the tests, ...
6 years, 4 months ago (2014-08-23 00:08:20 UTC) #3
danakj
PTAL @ PS3
6 years, 4 months ago (2014-08-23 00:08:42 UTC) #4
enne (OOO)
lgtm
6 years, 4 months ago (2014-08-23 00:11:33 UTC) #5
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 4 months ago (2014-08-23 00:12:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/497493004/40001
6 years, 4 months ago (2014-08-23 04:56:35 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-23 06:45:56 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-23 06:59:11 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/1662)
6 years, 4 months ago (2014-08-23 06:59:12 UTC) #10
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 4 months ago (2014-08-23 17:46:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/497493004/40001
6 years, 4 months ago (2014-08-23 17:47:19 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (40001) as 5a1c61a0b96848c5deb5cc3886337e7ae947d38d
6 years, 4 months ago (2014-08-23 22:18:27 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:32:04 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f080b5b78fd221901d34f179100bdf0e6827aa31
Cr-Commit-Position: refs/heads/master@{#291608}

Powered by Google App Engine
This is Rietveld 408576698