Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: chrome/browser/ui/webui/interstitials/interstitial_ui_browsertest.cc

Issue 497473002: OpenIntersitital test is marked as FLAKY. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/strings/utf_string_conversions.h" 5 #include "base/strings/utf_string_conversions.h"
6 #include "chrome/browser/chrome_notification_types.h" 6 #include "chrome/browser/chrome_notification_types.h"
7 #include "chrome/browser/devtools/devtools_window.h" 7 #include "chrome/browser/devtools/devtools_window.h"
8 #include "chrome/browser/devtools/devtools_window_testing.h" 8 #include "chrome/browser/devtools/devtools_window_testing.h"
9 #include "chrome/browser/ui/browser.h" 9 #include "chrome/browser/ui/browser.h"
10 #include "chrome/browser/ui/tabs/tab_strip_model.h" 10 #include "chrome/browser/ui/tabs/tab_strip_model.h"
(...skipping 14 matching lines...) Expand all
25 browser()->tab_strip_model()->GetActiveWebContents()->GetTitle()); 25 browser()->tab_strip_model()->GetActiveWebContents()->GetTitle());
26 26
27 // Should also be able to open and close devtools. 27 // Should also be able to open and close devtools.
28 DevToolsWindow* window = 28 DevToolsWindow* window =
29 DevToolsWindowTesting::OpenDevToolsWindowSync(browser(), true); 29 DevToolsWindowTesting::OpenDevToolsWindowSync(browser(), true);
30 EXPECT_TRUE(window); 30 EXPECT_TRUE(window);
31 DevToolsWindowTesting::CloseDevToolsWindowSync(window); 31 DevToolsWindowTesting::CloseDevToolsWindowSync(window);
32 } 32 }
33 }; 33 };
34 34
35 IN_PROC_BROWSER_TEST_F(InterstitialUITest, OpenInterstitial) { 35 IN_PROC_BROWSER_TEST_F(InterstitialUITest, FLAKY_OpenInterstitial) {
36 TestInterstitial( 36 TestInterstitial(
37 GURL("chrome://interstitials"), 37 GURL("chrome://interstitials"),
38 "Interstitials"); 38 "Interstitials");
39 // Invalid path should open the main page: 39 // Invalid path should open the main page:
40 TestInterstitial( 40 TestInterstitial(
41 GURL("chrome://interstitials/--invalid--"), 41 GURL("chrome://interstitials/--invalid--"),
42 "Interstitials"); 42 "Interstitials");
43 TestInterstitial( 43 TestInterstitial(
44 GURL("chrome://interstitials/ssl"), 44 GURL("chrome://interstitials/ssl"),
45 "Privacy error"); 45 "Privacy error");
46 TestInterstitial( 46 TestInterstitial(
47 GURL("chrome://interstitials/safebrowsing?type=malware"), 47 GURL("chrome://interstitials/safebrowsing?type=malware"),
48 "Security error"); 48 "Security error");
49 TestInterstitial( 49 TestInterstitial(
50 GURL("chrome://interstitials/safebrowsing?type=phishing"), 50 GURL("chrome://interstitials/safebrowsing?type=phishing"),
51 "Security error"); 51 "Security error");
52 TestInterstitial( 52 TestInterstitial(
53 GURL("chrome://interstitials/safebrowsing?type=clientside_malware"), 53 GURL("chrome://interstitials/safebrowsing?type=clientside_malware"),
54 "Security error"); 54 "Security error");
55 TestInterstitial( 55 TestInterstitial(
56 GURL("chrome://interstitials/safebrowsing?type=clientside_phishing"), 56 GURL("chrome://interstitials/safebrowsing?type=clientside_phishing"),
57 "Security error"); 57 "Security error");
58 } 58 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698