Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 497453003: Fix wrong constants are used for unstabbing D-Bus clients (Closed)

Created:
6 years, 3 months ago by satorux1
Modified:
6 years, 3 months ago
Reviewers:
hashimoto, zel
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix wrong constants are used for unstabbing D-Bus clients BUG=401192 TEST=existing tests Committed: https://crrev.com/d56f127a061c04a1820be448d61b9d985420d98e Cr-Commit-Position: refs/heads/master@{#291879}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chromeos/dbus/dbus_client_bundle.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
satorux1
satorux@chromium.org changed reviewers: + hashimoto@chromium.org, zelidrag@chromium.org
6 years, 3 months ago (2014-08-26 07:51:27 UTC) #1
satorux1
Found this minor bug while looking into crbug.com/405976
6 years, 3 months ago (2014-08-26 07:51:27 UTC) #2
hashimoto
lgtm
6 years, 3 months ago (2014-08-26 07:54:05 UTC) #3
satorux1
I was told that this issue is fixed in https://codereview.chromium.org/477663004/ too, but let me submit ...
6 years, 3 months ago (2014-08-26 07:55:48 UTC) #4
satorux1
The CQ bit was checked by satorux@chromium.org
6 years, 3 months ago (2014-08-26 07:56:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satorux@chromium.org/497453003/1
6 years, 3 months ago (2014-08-26 07:58:02 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 3 months ago (2014-08-26 08:48:48 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (1) as e1c9dccd196afe4bc6e82a372f78c781ddd256f8
6 years, 3 months ago (2014-08-26 10:23:00 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:41:53 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d56f127a061c04a1820be448d61b9d985420d98e
Cr-Commit-Position: refs/heads/master@{#291879}

Powered by Google App Engine
This is Rietveld 408576698