Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 497453002: Create Profile Overlay: Properly update the warning bubble and the "add" button, part 2. (Closed)

Created:
6 years, 4 months ago by Marc Treib
Modified:
6 years, 4 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Create Profile Overlay: Properly update the warning bubble and the "add" button, part 2. Followup to https://codereview.chromium.org/486283002/ which fixed only some of the cases. This CL ensures the bubble is updated also when the profile name is changed due to selecting a different avatar. BUG=405050 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291159

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/resources/options/manage_profile_overlay.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Marc Treib
Let's try this again. (Before, I was testing with new-profile-management, where the default profile names ...
6 years, 4 months ago (2014-08-21 08:05:56 UTC) #1
Pam (message me for reviews)
lgtm
6 years, 4 months ago (2014-08-21 14:25:29 UTC) #2
Marc Treib
The CQ bit was checked by treib@chromium.org
6 years, 4 months ago (2014-08-21 14:26:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/497453002/1
6 years, 4 months ago (2014-08-21 14:28:33 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 20:14:39 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (1) as 291159

Powered by Google App Engine
This is Rietveld 408576698