Refactor app list event handling and prerendering.

Refactor app list event handling and prerendering.

ContentsView should not be responsible for apps-grid-specific logic.

To this end, moved scroll and gesture event handling from ContentsView
to AppsGridView, removing the special cases for NAMED_PAGE_APPS. Also
moved some of the prerender logic from ContentsView to AppsGridView.

BUG=377381
Committed: https://crrev.com/e407013f55b72cb9e0a86aec541bd8eba5efe90f
Cr-Commit-Position: refs/heads/master@{#292591}

[Matt Giuca, 2014-08-26 04:53:02]

mgiuca@chromium.org changed reviewers:
+ calamity@chromium.org

[Matt Giuca, 2014-08-26 04:53:03]

Hmm, so I'll have to put almost-the-same logic *back* into ContentsView when I
handle scrolling at the top level. Which means I probably need to factor it out
into a "PaginationEventHandler" class or somesuch. But this is a good first
(logical) step.

[Matt Giuca, 2014-08-26 05:20:14]

I decided to move a bit more logic in the same CL (Patch Set 2).

[calamity, 2014-08-26 08:12:34]

https://codereview.chromium.org/497413003/diff/20001/ui/app_list/views/apps_c...
File ui/app_list/views/apps_container_view.h (right):

https://codereview.chromium.org/497413003/diff/20001/ui/app_list/views/apps_c...
ui/app_list/views/apps_container_view.h:69: virtual void
OnScrollEvent(ui::ScrollEvent* event) OVERRIDE;
Should this be part of the AppsGridView instead?

https://codereview.chromium.org/497413003/diff/20001/ui/app_list/views/conten...
File ui/app_list/views/contents_view.cc (right):

https://codereview.chromium.org/497413003/diff/20001/ui/app_list/views/conten...
ui/app_list/views/contents_view.cc:14: #include "ui/app_list/pagination_model.h"
This is already included in the header.

[Matt Giuca, 2014-08-28 00:35:21]

https://codereview.chromium.org/497413003/diff/20001/ui/app_list/views/apps_c...
File ui/app_list/views/apps_container_view.h (right):

https://codereview.chromium.org/497413003/diff/20001/ui/app_list/views/apps_c...
ui/app_list/views/apps_container_view.h:69: virtual void
OnScrollEvent(ui::ScrollEvent* event) OVERRIDE;
On 2014/08/26 08:12:34, calamity wrote:
> Should this be part of the AppsGridView instead?

Done.

https://codereview.chromium.org/497413003/diff/20001/ui/app_list/views/conten...
File ui/app_list/views/contents_view.cc (right):

https://codereview.chromium.org/497413003/diff/20001/ui/app_list/views/conten...
ui/app_list/views/contents_view.cc:14: #include "ui/app_list/pagination_model.h"
On 2014/08/26 08:12:34, calamity wrote:
> This is already included in the header.

Done.

[calamity, 2014-08-29 04:15:10]

https://codereview.chromium.org/497413003/diff/40001/ui/app_list/views/apps_g...
File ui/app_list/views/apps_grid_view.cc (right):

https://codereview.chromium.org/497413003/diff/40001/ui/app_list/views/apps_g...
ui/app_list/views/apps_grid_view.cc:899: void
AppsGridView::OnGestureEvent(ui::GestureEvent* event) {
nit: May as well move this behind all the View overrides (behind
ViewHierarchyChanged).

https://codereview.chromium.org/497413003/diff/40001/ui/app_list/views/apps_g...
ui/app_list/views/apps_grid_view.cc:900: switch (event->type()) {
I have a feeling this could change the folder behavior since the original code
used GetAppsPaginatinoModel(). In particular, I think gesture stuff that didn't
do anything before might do something now..

Could you please check that it hasn't changed. Otherwise, it should be a simple
matter of adding checks for folder_delegate_ in each of the event handlers.

[Matt Giuca, 2014-08-29 06:28:19]

https://codereview.chromium.org/497413003/diff/40001/ui/app_list/views/apps_g...
File ui/app_list/views/apps_grid_view.cc (right):

https://codereview.chromium.org/497413003/diff/40001/ui/app_list/views/apps_g...
ui/app_list/views/apps_grid_view.cc:899: void
AppsGridView::OnGestureEvent(ui::GestureEvent* event) {
On 2014/08/29 04:15:09, calamity wrote:
> nit: May as well move this behind all the View overrides (behind
> ViewHierarchyChanged).

Done.

https://codereview.chromium.org/497413003/diff/40001/ui/app_list/views/apps_g...
ui/app_list/views/apps_grid_view.cc:900: switch (event->type()) {
Seems to be OK, but haven't tested on ChromeOS (will do).

[calamity, 2014-08-29 07:43:52]

lgtm

[Matt Giuca, 2014-08-29 07:47:28]

https://codereview.chromium.org/497413003/diff/40001/ui/app_list/views/apps_g...
File ui/app_list/views/apps_grid_view.cc (right):

https://codereview.chromium.org/497413003/diff/40001/ui/app_list/views/apps_g...
ui/app_list/views/apps_grid_view.cc:900: switch (event->type()) {
Ugh, I can't test on ChromeOS because login manager is required for folders and
it's currently crashing.

But it looks like it will be fine. ash::AppListController does the overscrolling
by observing the AppsGridView instance of the PaginationModel. So any nested
PaginationModel will be ignored for overscroll purposes.

[Matt Giuca, 2014-08-29 07:48:05]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2014-08-29 07:48:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mgiuca@chromium.org/497413003/60001

[commit-bot: I haz the power, 2014-08-29 08:45:17]

Committed patchset #4 (id:60001) as f549ba9d967fad99f631b8cd7e3fede076f732e1

[commit-bot: I haz the power, 2014-09-10 03:07:01]

Patchset 4 (id:??) landed as
https://crrev.com/e407013f55b72cb9e0a86aec541bd8eba5efe90f
Cr-Commit-Position: refs/heads/master@{#292591}