Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: pkg/analysis_server/test/domain_completion_test.dart

Issue 497393002: Make more use of generated code in analysis server. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/test/domain_analysis_test.dart ('k') | pkg/analysis_server/test/edit/assists_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/domain_completion_test.dart
diff --git a/pkg/analysis_server/test/domain_completion_test.dart b/pkg/analysis_server/test/domain_completion_test.dart
index 5e75adebe9b602fb28e46f1a7b669e0ee4d73dd5..a6aadff1c8f8aa4651c6f7d89addaa77f05d6c13 100644
--- a/pkg/analysis_server/test/domain_completion_test.dart
+++ b/pkg/analysis_server/test/domain_completion_test.dart
@@ -9,9 +9,7 @@ import 'dart:async';
import 'package:analysis_server/src/constants.dart';
import 'package:analysis_server/src/domain_completion.dart';
import 'package:analysis_server/src/protocol.dart';
-import 'package:analysis_server/src/protocol2.dart' show
- CompletionGetSuggestionsParams, CompletionGetSuggestionsResult;
-import 'package:analysis_server/src/services/completion/completion_suggestion.dart';
+import 'package:analysis_server/src/protocol2.dart';
import 'package:analysis_server/src/services/index/index.dart' show Index;
import 'package:analysis_server/src/services/index/local_memory_index.dart';
import 'package:analysis_testing/reflective_tests.dart';
@@ -101,19 +99,16 @@ class CompletionTest extends AbstractAnalysisTest {
void processNotification(Notification notification) {
if (notification.event == COMPLETION_RESULTS) {
- String id = notification.getParameter(ID);
+ var params = new CompletionResultsParams.fromNotification(notification);
+ String id = params.id;
assertValidId(id);
if (id == completionId) {
expect(suggestionsDone, isFalse);
- replacementOffset = notification.getParameter(REPLACEMENT_OFFSET);
- replacementLength = notification.getParameter(REPLACEMENT_LENGTH);
- suggestionsDone = notification.getParameter(LAST);
+ replacementOffset = params.replacementOffset;
+ replacementLength = params.replacementLength;
+ suggestionsDone = params.last;
expect(suggestionsDone, isNotNull);
- suggestions = [];
- for (Map<String, Object> json in notification.getParameter(RESULTS)) {
- expect(json, isNotNull);
- suggestions.add(new CompletionSuggestion.fromJson(json));
- }
+ suggestions = params.results;
}
}
}
« no previous file with comments | « pkg/analysis_server/test/domain_analysis_test.dart ('k') | pkg/analysis_server/test/edit/assists_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698