Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Unified Diff: pkg/analysis_server/lib/src/computer/computer_navigation.dart

Issue 497393002: Make more use of generated code in analysis server. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/computer/computer_navigation.dart
diff --git a/pkg/analysis_server/lib/src/computer/computer_navigation.dart b/pkg/analysis_server/lib/src/computer/computer_navigation.dart
index ca8b97de8b3d186e94d82c4b12db9a31c2d3a3e3..244f7ddeff49b0d1a82c3f8a819a048582bd0fc6 100644
--- a/pkg/analysis_server/lib/src/computer/computer_navigation.dart
+++ b/pkg/analysis_server/lib/src/computer/computer_navigation.dart
@@ -5,7 +5,6 @@
library computer.navigation;
import 'package:analysis_server/src/protocol2.dart' as protocol;
-import 'package:analysis_server/src/constants.dart';
import 'package:analyzer/src/generated/ast.dart';
import 'package:analyzer/src/generated/element.dart';
import 'package:analyzer/src/generated/scanner.dart';
@@ -17,14 +16,14 @@ import 'package:analyzer/src/generated/scanner.dart';
class DartUnitNavigationComputer {
final CompilationUnit _unit;
- final List<Map<String, Object>> _regions = <Map<String, Object>>[];
+ final List<protocol.NavigationRegion> _regions = <protocol.NavigationRegion>[];
DartUnitNavigationComputer(this._unit);
/**
* Returns the computed navigation regions, not `null`.
*/
- List<Map<String, Object>> compute() {
+ List<protocol.NavigationRegion> compute() {
_unit.accept(new _DartUnitNavigationComputerVisitor(this));
return new List.from(_regions);
}
@@ -36,12 +35,8 @@ class DartUnitNavigationComputer {
if (element is FieldFormalParameterElement) {
element = (element as FieldFormalParameterElement).field;
}
- var elementJson = new protocol.Element.fromEngine(element).toJson();
- _regions.add({
- OFFSET: offset,
- LENGTH: length,
- TARGETS: [elementJson]
- });
+ protocol.Element target = new protocol.Element.fromEngine(element);
+ _regions.add(new protocol.NavigationRegion(offset, length, [target]));
}
void _addRegionForNode(AstNode node, Element element) {
« no previous file with comments | « pkg/analysis_server/lib/src/computer/computer_hover.dart ('k') | pkg/analysis_server/lib/src/computer/error.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698