Merge components/usb_service into device/usb.

Merge components/usb_service into device/usb.

Unify these two parts of out USB device support. The //device tree is
the cannonical location for hardware device APIs.

BUG=

Committed: https://crrev.com/d77718de5c3963cf0fe31e59c27c3e2aebfb26cb
Cr-Commit-Position: refs/heads/master@{#293246}

[Reilly Grant (use Gerrit), 2014-08-26 01:00:07]

Patchset #1 (id:1) has been deleted

[Reilly Grant (use Gerrit), 2014-08-26 01:02:37]

Patchset #1 (id:20001) has been deleted

[Reilly Grant (use Gerrit), 2014-08-26 02:05:35]

reillyg@chromium.org changed reviewers:
+ rockot@chromium.org, rpaquay@chromium.org, scheib@chromium.org

[Reilly Grant (use Gerrit), 2014-08-26 02:08:46]

reillyg@chromium.org changed reviewers:
+ erikwright@chromium.org

[Reilly Grant (use Gerrit), 2014-08-26 02:11:18]

reillyg@chromium.org changed reviewers:
+ darin@chromium.org, thestig@chromium.org

[Reilly Grant (use Gerrit), 2014-08-26 02:12:03]

Patchset #1 (id:40001) has been deleted

[Reilly Grant (use Gerrit), 2014-08-26 02:13:13]

Sorry for the wide reviewer list on this but I'm touching a number of high-level
GYP and GN files.

[erikwright (departed), 2014-08-26 16:59:08]

Could you provide some more background on why this became a component and is now
being uncomponentized?

It looks like it's being pushed down the stack into some core library? I'm
assuming this is the culmination of a lot of work to untangle dependencies on
chrome/ and/or content/?

[Ken Rockot(use gerrit already), 2014-08-26 17:01:16]

It became a component due to some outstanding (albeit undesirable)
//content dependencies.


On Tue, Aug 26, 2014 at 9:59 AM, <erikwright@chromium.org> wrote:

> Could you provide some more background on why this became a component and
> is now
> being uncomponentized?
>
> It looks like it's being pushed down the stack into some core library? I'm
> assuming this is the culmination of a lot of work to untangle dependencies
> on
> chrome/ and/or content/?
>
> https://codereview.chromium.org/497363004/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Reilly Grant (use Gerrit), 2014-08-26 17:01:57]

Dependencies I'm removing in https://codereview.chromium.org/507503002/.


On Tue, Aug 26, 2014 at 10:01 AM, Ken Rockot <rockot@chromium.org> wrote:

> It became a component due to some outstanding (albeit undesirable)
> //content dependencies.
>
>
> On Tue, Aug 26, 2014 at 9:59 AM, <erikwright@chromium.org> wrote:
>
>> Could you provide some more background on why this became a component and
>> is now
>> being uncomponentized?
>>
>> It looks like it's being pushed down the stack into some core library? I'm
>> assuming this is the culmination of a lot of work to untangle
>> dependencies on
>> chrome/ and/or content/?
>>
>> https://codereview.chromium.org/497363004/
>>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Ken Rockot(use gerrit already), 2014-08-26 17:35:25]

On 2014/08/26 17:01:57, reillyg wrote:
> Dependencies I'm removing in https://codereview.chromium.org/507503002/.
> 
> 
> On Tue, Aug 26, 2014 at 10:01 AM, Ken Rockot <mailto:rockot@chromium.org>
wrote:
> 
> > It became a component due to some outstanding (albeit undesirable)
> > //content dependencies.
> >
> >
> > On Tue, Aug 26, 2014 at 9:59 AM, <mailto:erikwright@chromium.org> wrote:
> >
> >> Could you provide some more background on why this became a component and
> >> is now
> >> being uncomponentized?
> >>
> >> It looks like it's being pushed down the stack into some core library? I'm
> >> assuming this is the culmination of a lot of work to untangle
> >> dependencies on
> >> chrome/ and/or content/?
> >>
> >> https://codereview.chromium.org/497363004/
> >>
> >
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

For a little more clarification, it was componentized because we wanted
non-Chrome (and namely //extensions) code to be able to use it. We've been
strict about preserving //device's independence from //content, and so building
usb_service as a standalone component with //content dependencies made sense.

I would not say that it's being uncomponentized. Perhaps it makes sense to
eventually move //device into //components/device. Each of the services provided
therein function as standalone components already anyway.

[erikwright (departed), 2014-08-26 17:56:39]

On 2014/08/26 17:35:25, Ken Rockot wrote:
> On 2014/08/26 17:01:57, reillyg wrote:
> > Dependencies I'm removing in https://codereview.chromium.org/507503002/.
> > 
> > 
> > On Tue, Aug 26, 2014 at 10:01 AM, Ken Rockot <mailto:rockot@chromium.org>
> wrote:
> > 
> > > It became a component due to some outstanding (albeit undesirable)
> > > //content dependencies.
> > >
> > >
> > > On Tue, Aug 26, 2014 at 9:59 AM, <mailto:erikwright@chromium.org> wrote:
> > >
> > >> Could you provide some more background on why this became a component and
> > >> is now
> > >> being uncomponentized?
> > >>
> > >> It looks like it's being pushed down the stack into some core library?
I'm
> > >> assuming this is the culmination of a lot of work to untangle
> > >> dependencies on
> > >> chrome/ and/or content/?
> > >>
> > >> https://codereview.chromium.org/497363004/
> > >>
> > >
> > >
> > 
> > To unsubscribe from this group and stop receiving emails from it, send an
> email
> > to mailto:chromium-reviews+unsubscribe@chromium.org.
> 
> For a little more clarification, it was componentized because we wanted
> non-Chrome (and namely //extensions) code to be able to use it. We've been
> strict about preserving //device's independence from //content, and so
building
> usb_service as a standalone component with //content dependencies made sense.
> 
> I would not say that it's being uncomponentized. Perhaps it makes sense to
> eventually move //device into //components/device. Each of the services
provided
> therein function as standalone components already anyway.

It sounds to me like //device is even more restrictive than //components and, as
such, an implementation that lives there is "better than componentized". Am I
mistaken?

Anyway, //components/... LGTM.

[Ken Rockot(use gerrit already), 2014-08-29 19:53:13]

lgtm

[Reilly Grant (use Gerrit), 2014-08-29 20:20:07]

reillyg@chromium.org changed reviewers:
+ brettw@chromium.org

[Reilly Grant (use Gerrit), 2014-08-29 20:20:30]

Adding brettw for //BUILD.gn.

[scheib, 2014-08-29 21:27:33]

lgtm

[brettw, 2014-08-29 22:52:48]

gn buildfiles lgtm

[Reilly Grant (use Gerrit), 2014-08-29 22:59:43]

reillyg@chromium.org changed reviewers:
+ derat@chromium.org, ttuttle@chromium.org

[Reilly Grant (use Gerrit), 2014-08-29 23:00:49]

Adding derat@ and ttuttle@ for the dependencies on +chromeos and +net/base added
to device/usb/DEPS. These aren't new, just moved from
components/usb_service/DEPS.

[Daniel Erat, 2014-08-29 23:06:33]

lgtm for chromeos in device/usb/DEPS

[Deprecated (see juliatuttle), 2014-08-29 23:43:55]

On 2014/08/29 23:00:49, reillyg wrote:
> Adding derat@ and ttuttle@ for the dependencies on +chromeos and +net/base
added
> to device/usb/DEPS. These aren't new, just moved from
> components/usb_service/DEPS.

lgtm. Sad that that whole dep is needed just for io_buffer.h.

[Reilly Grant (use Gerrit), 2014-08-29 23:45:50]

On 2014/08/29 23:43:55, ttuttle wrote:
> lgtm. Sad that that whole dep is needed just for io_buffer.h.

I've considered suggesting that IOBuffer move to //base since it's really just a
fancy scoped_ptr<char>.

[Reilly Grant (use Gerrit), 2014-09-02 17:32:35]

reillyg@chromium.org changed reviewers:
+ dgozman@chromium.org
- darin@chromium.org

[Reilly Grant (use Gerrit), 2014-09-02 17:33:36]

thestig, dgozman,

Please take a look at the //chrome/browser and //chrome/browser/devtools
changes.

[dgozman, 2014-09-02 19:38:26]

chrome/browser/devtools lgtm modulo DEPS file

https://codereview.chromium.org/497363004/diff/120001/chrome/browser/devtools...
File chrome/browser/devtools/device/usb/DEPS (right):

https://codereview.chromium.org/497363004/diff/120001/chrome/browser/devtools...
chrome/browser/devtools/device/usb/DEPS:2: "+device/common",
I don't see where this is used.

https://codereview.chromium.org/497363004/diff/120001/chrome/browser/devtools...
chrome/browser/devtools/device/usb/DEPS:3: "+device/usb",
Is this necessary? I see "device/usb" mentioned in chrome/browser/DEPS.

[Reilly Grant (use Gerrit), 2014-09-02 22:48:55]

https://codereview.chromium.org/497363004/diff/120001/chrome/browser/devtools...
File chrome/browser/devtools/device/usb/DEPS (right):

https://codereview.chromium.org/497363004/diff/120001/chrome/browser/devtools...
chrome/browser/devtools/device/usb/DEPS:2: "+device/common",
On 2014/09/02 19:38:25, dgozman wrote:
> I don't see where this is used.

It's not. It's a bad merge. Ihe directory is now called //device/core.

https://codereview.chromium.org/497363004/diff/120001/chrome/browser/devtools...
chrome/browser/devtools/device/usb/DEPS:3: "+device/usb",
On 2014/09/02 19:38:25, dgozman wrote:
> Is this necessary? I see "device/usb" mentioned in chrome/browser/DEPS.

Agreed. The whole file is unnecessary because of ../../../DEPS.

[Reilly Grant (use Gerrit), 2014-09-03 17:15:25]

reillyg@chromium.org changed reviewers:
+ sky@chromium.org

[Reilly Grant (use Gerrit), 2014-09-03 17:15:49]

Adding sky@ as another possible reviewer for the //chrome/browser changes.

[Lei Zhang, 2014-09-03 18:19:48]

chrome/ lgtm, sorry if I missed this earlier.

[Reilly Grant (use Gerrit), 2014-09-03 18:34:37]

Patchset #5 (id:160001) has been deleted

[Reilly Grant (use Gerrit), 2014-09-03 20:50:36]

The CQ bit was checked by reillyg@chromium.org

[commit-bot: I haz the power, 2014-09-03 20:54:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/reillyg@chromium.org/497363004/180001

[sky, 2014-09-03 21:28:58]

chrome/browser LGTM

[commit-bot: I haz the power, 2014-09-04 00:59:03]

Committed patchset #5 (id:180001) as be2db17f12b8c0e12d833f630a448413018295a1

[commit-bot: I haz the power, 2014-09-10 03:29:21]

Patchset 5 (id:??) landed as
https://crrev.com/d77718de5c3963cf0fe31e59c27c3e2aebfb26cb
Cr-Commit-Position: refs/heads/master@{#293246}