Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 497333002: Add options_menu.js to remoting_resources dependencies (Closed)

Created:
6 years, 4 months ago by Wez
Modified:
6 years, 3 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Add options_menu.js to remoting_resources dependencies BUG=406055 Committed: https://crrev.com/ca24846fccae54129199eca2e4cc82a13afab9ac Cr-Commit-Position: refs/heads/master@{#291743}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M remoting/remoting.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Wez
6 years, 4 months ago (2014-08-23 00:33:10 UTC) #1
Jamie
lgtm
6 years, 4 months ago (2014-08-25 16:58:03 UTC) #2
Wez
The CQ bit was checked by wez@chromium.org
6 years, 4 months ago (2014-08-25 17:55:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/497333002/1
6 years, 4 months ago (2014-08-25 17:56:07 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel_swarming on tryserver.chromium.mac ...
6 years, 4 months ago (2014-08-25 19:01:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (1) as 8173d2b381962d4fc329c2aad54e70127570f89c
6 years, 4 months ago (2014-08-25 19:45:42 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:36:55 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ca24846fccae54129199eca2e4cc82a13afab9ac
Cr-Commit-Position: refs/heads/master@{#291743}

Powered by Google App Engine
This is Rietveld 408576698