Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1146)

Side by Side Diff: build/android/pylib/utils/findbugs.py

Issue 49733002: Fix a typo about findbugs_args (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import optparse 5 import optparse
6 import os 6 import os
7 import re 7 import re
8 import shlex 8 import shlex
9 import subprocess 9 import subprocess
10 import sys 10 import sys
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 if len(system_classes): 115 if len(system_classes):
116 cmd = '%s -auxclasspath %s ' % (cmd, ':'.join(system_classes)) 116 cmd = '%s -auxclasspath %s ' % (cmd, ':'.join(system_classes))
117 117
118 if classes_to_analyze: 118 if classes_to_analyze:
119 cmd = '%s -onlyAnalyze %s ' % (cmd, classes_to_analyze) 119 cmd = '%s -onlyAnalyze %s ' % (cmd, classes_to_analyze)
120 120
121 if exclude: 121 if exclude:
122 cmd = '%s -exclude %s ' % (cmd, os.path.abspath(exclude)) 122 cmd = '%s -exclude %s ' % (cmd, os.path.abspath(exclude))
123 123
124 if findbug_args: 124 if findbug_args:
125 cmd = '%s %s ' % (cmd, fingbug_args) 125 cmd = '%s %s ' % (cmd, findbug_args)
126 126
127 127
128 chrome_classes = _GetChromeClasses(release_version) 128 chrome_classes = _GetChromeClasses(release_version)
129 if not chrome_classes: 129 if not chrome_classes:
130 return 1 130 return 1
131 cmd = '%s %s ' % (cmd, chrome_classes) 131 cmd = '%s %s ' % (cmd, chrome_classes)
132 132
133 proc = subprocess.Popen(shlex.split(cmd), 133 proc = subprocess.Popen(shlex.split(cmd),
134 stdout=subprocess.PIPE, stderr=subprocess.PIPE) 134 stdout=subprocess.PIPE, stderr=subprocess.PIPE)
135 out, err = proc.communicate() 135 out, err = proc.communicate()
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
222 222
223 def main(argv): 223 def main(argv):
224 parser = GetCommonParser() 224 parser = GetCommonParser()
225 options, _ = parser.parse_args() 225 options, _ = parser.parse_args()
226 226
227 return Run(options) 227 return Run(options)
228 228
229 229
230 if __name__ == '__main__': 230 if __name__ == '__main__':
231 sys.exit(main(sys.argv)) 231 sys.exit(main(sys.argv))
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698