Switch to using WebSettings only for accessibilityEnabled and inlineTextBoxAccess

Switch to using WebSettings only for accessibilityEnabled and inlineTextBoxAccess

Depends on https://codereview.chromium.org/495763005/

BUG=406622
Committed: https://crrev.com/efb9ce72f54e7196e47df2e76e6dba1616927376
Cr-Commit-Position: refs/heads/master@{#292803}

[dmazzoni, 2014-08-22 23:20:23]

https://codereview.chromium.org/497273002/diff/20001/content/renderer/accessi...
File content/renderer/accessibility/renderer_accessibility_complete.cc (right):

https://codereview.chromium.org/497273002/diff/20001/content/renderer/accessi...
content/renderer/accessibility/renderer_accessibility_complete.cc:41: WebView*
web_view = render_frame_->GetRenderView()->GetWebView();
Why does test_runner call this on the WebFrame while this gets the WebView, then
WebSettings? If you have a convenience function on WebFrame, use that here.

[aboxhall, 2014-08-22 23:24:10]

https://codereview.chromium.org/497273002/diff/20001/content/renderer/accessi...
File content/renderer/accessibility/renderer_accessibility_complete.cc (right):

https://codereview.chromium.org/497273002/diff/20001/content/renderer/accessi...
content/renderer/accessibility/renderer_accessibility_complete.cc:41: WebView*
web_view = render_frame_->GetRenderView()->GetWebView();
On 2014/08/22 23:20:23, dmazzoni wrote:
> Why does test_runner call this on the WebFrame while this gets the WebView,
then
> WebSettings? If you have a convenience function on WebFrame, use that here.

How do I get a reference to a WebFrame here?

[dmazzoni, 2014-08-22 23:31:23]

https://codereview.chromium.org/497273002/diff/20001/content/renderer/accessi...
File content/renderer/accessibility/renderer_accessibility_complete.cc (right):

https://codereview.chromium.org/497273002/diff/20001/content/renderer/accessi...
content/renderer/accessibility/renderer_accessibility_complete.cc:41: WebView*
web_view = render_frame_->GetRenderView()->GetWebView();
On 2014/08/22 23:24:10, aboxhall wrote:
> On 2014/08/22 23:20:23, dmazzoni wrote:
> > Why does test_runner call this on the WebFrame while this gets the WebView,
> then
> > WebSettings? If you have a convenience function on WebFrame, use that here.
> 
> How do I get a reference to a WebFrame here?

render_frame->GetWebFrame()

[aboxhall, 2014-08-22 23:41:30]

On 2014/08/22 23:31:23, dmazzoni wrote:
>
https://codereview.chromium.org/497273002/diff/20001/content/renderer/accessi...
> File content/renderer/accessibility/renderer_accessibility_complete.cc
(right):
> 
>
https://codereview.chromium.org/497273002/diff/20001/content/renderer/accessi...
> content/renderer/accessibility/renderer_accessibility_complete.cc:41: WebView*
> web_view = render_frame_->GetRenderView()->GetWebView();
> On 2014/08/22 23:24:10, aboxhall wrote:
> > On 2014/08/22 23:20:23, dmazzoni wrote:
> > > Why does test_runner call this on the WebFrame while this gets the
WebView,
> > then
> > > WebSettings? If you have a convenience function on WebFrame, use that
here.
> > 
> > How do I get a reference to a WebFrame here?
> 
> render_frame->GetWebFrame()

Done.

[dmazzoni, 2014-08-22 23:48:05]

lgtm

[jam, 2014-08-25 01:59:35]

lgtm

[aboxhall, 2014-08-30 17:26:35]

The CQ bit was checked by aboxhall@chromium.org

[commit-bot: I haz the power, 2014-08-30 17:27:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/aboxhall@chromium.org/497273002/60001

[commit-bot: I haz the power, 2014-08-30 17:40:07]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/48526)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/53854)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-30 17:41:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-30 17:41:15]

Try jobs failed on following builders:
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[aboxhall, 2014-08-30 18:06:25]

The CQ bit was checked by aboxhall@chromium.org

[commit-bot: I haz the power, 2014-08-30 18:06:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/aboxhall@chromium.org/497273002/80001

[commit-bot: I haz the power, 2014-08-30 19:05:35]

Committed patchset #5 (id:80001) as 9a5a2ff8ce2bbb400a451348a35c7f1811623b3a

[commit-bot: I haz the power, 2014-09-10 03:14:42]

Patchset 5 (id:??) landed as
https://crrev.com/efb9ce72f54e7196e47df2e76e6dba1616927376
Cr-Commit-Position: refs/heads/master@{#292803}