Use both APIs (WebAXObject and WebSettings) for enabling accessibility

Use both APIs for enabling accessibility

https://codereview.chromium.org/491483006

BUG=406622
Committed: https://crrev.com/62ea4420572a57354518d9081e4150889b836d88
Cr-Commit-Position: refs/heads/master@{#292490}

[dmazzoni, 2014-08-22 23:14:19]

lgtm

[dmazzoni, 2014-08-22 23:20:11]

https://codereview.chromium.org/497263002/diff/1/content/renderer/accessibili...
File content/renderer/accessibility/renderer_accessibility_complete.cc (right):

https://codereview.chromium.org/497263002/diff/1/content/renderer/accessibili...
content/renderer/accessibility/renderer_accessibility_complete.cc:42: WebView*
web_view = render_frame_->GetRenderView()->GetWebView();
Wait - why does test_runner call this on the WebFrame while this gets the
WebView, then WebSettings? If you have a convenience function on WebFrame, use
that here.

[aboxhall, 2014-08-22 23:23:14]

https://codereview.chromium.org/497263002/diff/1/content/renderer/accessibili...
File content/renderer/accessibility/renderer_accessibility_complete.cc (right):

https://codereview.chromium.org/497263002/diff/1/content/renderer/accessibili...
content/renderer/accessibility/renderer_accessibility_complete.cc:42: WebView*
web_view = render_frame_->GetRenderView()->GetWebView();
On 2014/08/22 23:20:11, dmazzoni wrote:
> Wait - why does test_runner call this on the WebFrame while this gets the
> WebView, then WebSettings? If you have a convenience function on WebFrame, use
> that here.

This doesn't have a WebFrame AFAIK. Am I missing something?

[jam, 2014-08-25 01:58:43]

lgtm

[aboxhall, 2014-08-25 22:50:19]

Removed setAccessibility methods from WebFrame.

[aboxhall, 2014-08-27 22:22:43]

The CQ bit was checked by aboxhall@chromium.org

[commit-bot: I haz the power, 2014-08-27 22:24:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/aboxhall@chromium.org/497263002/40001

[commit-bot: I haz the power, 2014-08-27 23:14:27]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/47247)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/52604)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-27 23:18:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-27 23:18:17]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/47277)

[aboxhall, 2014-08-28 21:06:40]

The CQ bit was checked by aboxhall@chromium.org

[commit-bot: I haz the power, 2014-08-28 21:07:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/aboxhall@chromium.org/497263002/40001

[commit-bot: I haz the power, 2014-08-28 22:10:49]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-28 23:24:54]

Committed patchset #3 (id:40001) as 688e45c6c5954e2638073d1588d1ede3974f7aa3

[commit-bot: I haz the power, 2014-09-10 03:03:15]

Patchset 3 (id:??) landed as
https://crrev.com/62ea4420572a57354518d9081e4150889b836d88
Cr-Commit-Position: refs/heads/master@{#292490}