Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 497213002: Mark some destructors as virtual. (Closed)

Created:
6 years, 4 months ago by Alexei Svitkine (slow)
Modified:
6 years, 4 months ago
Reviewers:
jwd, Steven Holte
CC:
chromium-reviews, Ilya Sherman, asvitkine+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Mark some destructors as virtual. Since the classes have virtual functions. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291510

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M components/rappor/byte_vector_utils.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Alexei Svitkine (slow)
6 years, 4 months ago (2014-08-22 18:55:45 UTC) #1
Steven Holte
lgtm
6 years, 4 months ago (2014-08-22 19:06:23 UTC) #2
Alexei Svitkine (slow)
The CQ bit was checked by asvitkine@chromium.org
6 years, 4 months ago (2014-08-22 19:11:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/497213002/1
6 years, 4 months ago (2014-08-22 19:14:31 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 19:14:32 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-08-22 19:14:33 UTC) #6
Alexei Svitkine (slow)
+jwd
6 years, 4 months ago (2014-08-22 19:18:45 UTC) #7
jwd
lgtm
6 years, 4 months ago (2014-08-22 20:09:23 UTC) #8
Alexei Svitkine (slow)
The CQ bit was checked by asvitkine@chromium.org
6 years, 4 months ago (2014-08-22 20:32:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/497213002/1
6 years, 4 months ago (2014-08-22 20:32:28 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 21:33:06 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 21:39:13 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (1) as 291510

Powered by Google App Engine
This is Rietveld 408576698