Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 497173002: perf: Make RAF heavy first frame test do what it says (Closed)

Created:
6 years, 4 months ago by Sami
Modified:
6 years, 3 months ago
Reviewers:
brianderson
CC:
chromium-reviews, telemetry+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

perf: Make RAF heavy first frame test do what it says The requestAnimationFrame test which simulates a large jank in the first rAF callback (raf.html?heavy_first_frame) was actually adding the delay to every callback. This patch fixes the synthetic delay to use the correct one-shot mode. BUG=391005 Committed: https://crrev.com/ca0fe2ef7016eefc24bd860d25566a9f1577a8c1 Cr-Commit-Position: refs/heads/master@{#291886}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/perf/page_sets/tough_scheduling_cases.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Sami
6 years, 4 months ago (2014-08-22 17:08:27 UTC) #1
brianderson
lgtm
6 years, 4 months ago (2014-08-22 18:11:35 UTC) #2
Sami
The CQ bit was checked by skyostil@chromium.org
6 years, 3 months ago (2014-08-26 09:17:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/497173002/1
6 years, 3 months ago (2014-08-26 09:18:47 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-26 10:18:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (1) as fdf168ae0df697b5d19a7a76538c9cedaf45a9e9
6 years, 3 months ago (2014-08-26 11:31:47 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:42:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ca0fe2ef7016eefc24bd860d25566a9f1577a8c1
Cr-Commit-Position: refs/heads/master@{#291886}

Powered by Google App Engine
This is Rietveld 408576698