Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 497163002: Componentize component_updater: Delete old test data files. (Closed)

Created:
6 years, 4 months ago by tommycli
Modified:
6 years, 3 months ago
Reviewers:
waffles
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Componentize component_updater: Delete old test data files. This is step 3 of this: 1) Copy the binary files into components/test/data. 2) Move the tests. 3) Delete the (now unused) old binary files in chrome/test/data. BUG=371463 Committed: https://crrev.com/1760d49ce7113180c0ebe1be791be99e50b14652 Cr-Commit-Position: refs/heads/master@{#292186}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -167 lines) Patch
D chrome/test/data/components/binary_bsdiff_patch.bin View Binary file 0 comments Download
D chrome/test/data/components/binary_courgette_patch.bin View Binary file 0 comments Download
D chrome/test/data/components/binary_input.bin View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/test/data/components/binary_output.bin View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/test/data/components/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc.pem View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/test/data/components/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1/a_changing_binary_file View Binary file 0 comments Download
D chrome/test/data/components/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1/a_changing_text_file View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/components/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1/a_static_text_file View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/components/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1/manifest.json View 1 chunk +0 lines, -5 lines 0 comments Download
D chrome/test/data/components/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1to2/commands.json View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/components/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1to2/f0 View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/components/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1to2/f1 View Binary file 0 comments Download
D chrome/test/data/components/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1to2/f2 View 1 chunk +0 lines, -5 lines 0 comments Download
D chrome/test/data/components/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1to2_bad/commands.json View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/components/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1to2_bad/f1 View 1 chunk +0 lines, -5 lines 0 comments Download
D chrome/test/data/components/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1to2_bad/f2 View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/components/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1to2_bad/f3 View Binary file 0 comments Download
D chrome/test/data/components/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_2/a_changing_binary_file View Binary file 0 comments Download
D chrome/test/data/components/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_2/a_changing_text_file View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/components/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_2/a_static_text_file View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/components/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_2/manifest.json View 1 chunk +0 lines, -5 lines 0 comments Download
D chrome/test/data/components/ihfokbkgjpifnbbojhneepfflplebdkc_1.crx View Binary file 0 comments Download
D chrome/test/data/components/ihfokbkgjpifnbbojhneepfflplebdkc_1to2.crx View Binary file 0 comments Download
D chrome/test/data/components/ihfokbkgjpifnbbojhneepfflplebdkc_1to2_bad.crx View Binary file 0 comments Download
D chrome/test/data/components/ihfokbkgjpifnbbojhneepfflplebdkc_2.crx View Binary file 0 comments Download
D chrome/test/data/components/jebgalgnebhfojomionfpkfelancnnkf.crx View Binary file 0 comments Download
D chrome/test/data/components/jebgalgnebhfojomionfpkfelancnnkf.pem View 1 chunk +0 lines, -15 lines 0 comments Download
D chrome/test/data/components/jebgalgnebhfojomionfpkfelancnnkf/component1.dll View Binary file 0 comments Download
D chrome/test/data/components/jebgalgnebhfojomionfpkfelancnnkf/manifest.json View 1 chunk +0 lines, -9 lines 0 comments Download
D chrome/test/data/components/updatecheck_diff_reply_1.xml View 1 chunk +0 lines, -15 lines 0 comments Download
D chrome/test/data/components/updatecheck_diff_reply_2.xml View 1 chunk +0 lines, -16 lines 0 comments Download
D chrome/test/data/components/updatecheck_diff_reply_3.xml View 1 chunk +0 lines, -6 lines 0 comments Download
D chrome/test/data/components/updatecheck_reply_1.xml View 1 chunk +0 lines, -15 lines 0 comments Download
D chrome/test/data/components/updatecheck_reply_2.xml View 1 chunk +0 lines, -15 lines 0 comments Download
D chrome/test/data/components/updatecheck_reply_3.xml View 1 chunk +0 lines, -6 lines 0 comments Download
D chrome/test/data/components/updatecheck_reply_empty View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/components/updatecheck_reply_noupdate.xml View 1 chunk +0 lines, -6 lines 0 comments Download
M tools/checkperms/checkperms.py View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tommycli
waffles: PTAL. This is step 3 of the CLs you suggested. Thanks!
6 years, 4 months ago (2014-08-22 16:51:02 UTC) #1
waffles
lgtm, though of course wait to submit until the opportune moment
6 years, 4 months ago (2014-08-22 19:43:52 UTC) #2
tommycli
The CQ bit was checked by tommycli@chromium.org
6 years, 3 months ago (2014-08-27 17:25:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommycli@chromium.org/497163002/1
6 years, 3 months ago (2014-08-27 17:26:41 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 97ca39447bbdd6982c9efaf60d700061369eedb8
6 years, 3 months ago (2014-08-27 18:20:10 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:52:48 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1760d49ce7113180c0ebe1be791be99e50b14652
Cr-Commit-Position: refs/heads/master@{#292186}

Powered by Google App Engine
This is Rietveld 408576698