media/cdm/ppapi/cdm_adapter.h - Issue 497153005: ReleaseSession() should call RemoveSession()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/cdm/ppapi/cdm_adapter.h

Issue 497153005: ReleaseSession() should call RemoveSession() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/cdm/ppapi/cdm_adapter.h

diff --git a/media/cdm/ppapi/cdm_adapter.h b/media/cdm/ppapi/cdm_adapter.h

index 07b5ad1296a482d1311c3e40b5991d4c8477e6fc..749093e01ffe85e2c253ffc7e0ed7c0ce0f2773e 100644

--- a/media/cdm/ppapi/cdm_adapter.h

+++ b/media/cdm/ppapi/cdm_adapter.h

@@ -67,12 +67,12 @@ class CdmAdapter : public pp::Instance,

virtual void UpdateSession(uint32_t promise_id,

const std::string& web_session_id,

pp::VarArrayBuffer response) OVERRIDE;

- // TODO(jrummell): Rename to CloseSession().

+ // TODO(jrummell): Rename to RemoveSession().

virtual void ReleaseSession(uint32_t promise_id,

const std::string& web_session_id) OVERRIDE;

xhwang 2014/08/23 00:01:48 Will we also remove this in CDM.h?

jrummell 2014/08/23 00:27:15 It is already called RemoveSession() in CDM6.

// TODO(jrummell): Pass these 2 functions through Pepper and add OVERRIDE.

- virtual void RemoveSession(uint32_t promise_id,

- const std::string& web_session_id);

+ virtual void CloseSession(uint32_t promise_id,

+ const std::string& web_session_id);

virtual void GetUsableKeyIds(uint32_t promise_id,

const std::string& web_session_id);

virtual void Decrypt(

« no previous file with comments | « no previous file | media/cdm/ppapi/cdm_adapter.cc » ('j') | media/cdm/ppapi/cdm_adapter.cc » ('J')