Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 497143002: Revert of Directly composited images are images: ASSERT that (Closed)

Created:
6 years, 4 months ago by jabdelmalek
Modified:
6 years, 4 months ago
CC:
abarth-chromium, blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1
Project:
blink
Visibility:
Public.

Description

Revert of Directly composited images are images: ASSERT that (patchset #2 of https://codereview.chromium.org/491773002/) Reason for revert: Breaking android bots most of the time Original issue's description: > Directly composited images are images: ASSERT that > > isDirectlyCompositedImage only applies to images. ASSERT that and > make callers do all the isImage() testing. > > BUG=405803 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180721 TBR=vollick@chromium.org,benm@chromium.org,noel@chromium.org NOTREECHECKS=true NOTRY=true BUG=405803 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180779

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M Source/core/rendering/compositing/CompositedLayerMapping.cpp View 4 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jabdelmalek
Created Revert of Directly composited images are images: ASSERT that
6 years, 4 months ago (2014-08-22 15:35:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jabdelmalek@google.com/497143002/1
6 years, 4 months ago (2014-08-22 15:35:49 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (1) as 180779
6 years, 4 months ago (2014-08-22 15:37:06 UTC) #3
Noel Gordon
6 years, 4 months ago (2014-08-22 16:22:03 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698