Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: chrome/browser/renderer_host/chrome_extension_message_filter.cc

Issue 497103002: Move ChromeExtensionHostMsg_AttachGuest to extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move to extensions/renderer/guest_view/. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/chrome_extension_message_filter.cc
diff --git a/chrome/browser/renderer_host/chrome_extension_message_filter.cc b/chrome/browser/renderer_host/chrome_extension_message_filter.cc
index 2326da2c0c7c5c958942a8a49219e190857edd8d..ae531912c1f34d9101b88bf3c562156c0d3c2a63 100644
--- a/chrome/browser/renderer_host/chrome_extension_message_filter.cc
+++ b/chrome/browser/renderer_host/chrome_extension_message_filter.cc
@@ -22,8 +22,6 @@
#include "content/public/browser/notification_service.h"
#include "content/public/browser/render_process_host.h"
#include "extensions/browser/extension_system.h"
-#include "extensions/browser/guest_view/guest_view_base.h"
-#include "extensions/browser/guest_view/guest_view_manager.h"
#include "extensions/common/api/messaging/message.h"
#include "extensions/common/constants.h"
#include "extensions/common/extension_messages.h"
@@ -90,7 +88,6 @@ bool ChromeExtensionMessageFilter::OnMessageReceived(
const IPC::Message& message) {
bool handled = true;
IPC_BEGIN_MESSAGE_MAP(ChromeExtensionMessageFilter, message)
- IPC_MESSAGE_HANDLER(ChromeExtensionHostMsg_AttachGuest, OnAttachGuest)
IPC_MESSAGE_HANDLER(ChromeViewHostMsg_CanTriggerClipboardRead,
OnCanTriggerClipboardRead)
IPC_MESSAGE_HANDLER(ChromeViewHostMsg_CanTriggerClipboardWrite,
@@ -119,7 +116,6 @@ bool ChromeExtensionMessageFilter::OnMessageReceived(
void ChromeExtensionMessageFilter::OverrideThreadForMessage(
const IPC::Message& message, BrowserThread::ID* thread) {
switch (message.type()) {
- case ChromeExtensionHostMsg_AttachGuest::ID:
case ExtensionHostMsg_PostMessage::ID:
case ExtensionHostMsg_CloseChannel::ID:
*thread = BrowserThread::UI;
@@ -152,24 +148,6 @@ void ChromeExtensionMessageFilter::OnCanTriggerClipboardWrite(
origin, render_process_id_, APIPermission::kClipboardWrite));
}
-void ChromeExtensionMessageFilter::OnAttachGuest(
- int routing_id,
- int element_instance_id,
- int guest_instance_id,
- const base::DictionaryValue& params) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
- extensions::GuestViewManager* manager =
- extensions::GuestViewManager::FromBrowserContext(profile_);
- if (!manager)
- return;
-
- manager->AttachGuest(render_process_id_,
- routing_id,
- element_instance_id,
- guest_instance_id,
- params);
-}
-
void ChromeExtensionMessageFilter::OnOpenChannelToExtension(
int routing_id,
const ExtensionMsg_ExternalConnectionInfo& info,

Powered by Google App Engine
This is Rietveld 408576698