Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 497103002: Move ChromeExtensionHostMsg_AttachGuest to extensions. (Closed)

Created:
6 years, 4 months ago by Xi Han
Modified:
6 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, wjmaclean, lfg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

1. Rename ChromeExtensionHostMsg_AttachGuest as ExtensionHostMsg_AttachGuest. 2. Move its ipc handler to extensions. BUG=352290 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291542

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Move guest_view_internal_custom_bindings.h(.cc) to extensions. #

Total comments: 1

Patch Set 4 : Move to extensions/renderer/guest_view/. #

Total comments: 4

Patch Set 5 : Move guest_view_internal register to dispatcher in extensions. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -147 lines) Patch
M chrome/browser/renderer_host/chrome_extension_message_filter.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/renderer_host/chrome_extension_message_filter.cc View 4 chunks +0 lines, -22 lines 0 comments Download
M chrome/chrome_renderer.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/extensions/chrome_extension_messages.h View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc View 1 2 3 4 2 chunks +0 lines, -5 lines 0 comments Download
D chrome/renderer/extensions/guest_view_internal_custom_bindings.h View 1 2 1 chunk +0 lines, -35 lines 0 comments Download
M chrome/renderer/extensions/guest_view_internal_custom_bindings.cc View 1 2 1 chunk +0 lines, -65 lines 0 comments Download
M extensions/browser/extension_message_filter.h View 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/browser/extension_message_filter.cc View 1 4 chunks +22 lines, -0 lines 0 comments Download
M extensions/common/extension_messages.h View 1 chunk +8 lines, -0 lines 0 comments Download
M extensions/extensions.gyp View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/renderer/dispatcher.cc View 1 2 3 4 2 chunks +5 lines, -0 lines 0 comments Download
A + extensions/renderer/guest_view/OWNERS View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/renderer/guest_view/guest_view_internal_custom_bindings.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
Xi Han
6 years, 4 months ago (2014-08-22 14:42:08 UTC) #1
Fady Samuel
lgtm
6 years, 4 months ago (2014-08-22 14:44:38 UTC) #2
Xi Han
kenrb@chromium.org: Please review changes in: -chrome/common/extensions/chrome_extension_messages.h -extensions/common/extension_messages.h kalman@chromium.org: Please review changes in: -chrome/renderer/extensions/guest_view_internal_custom_bindings.cc -extensions/browser/extension_message_filter.h -extensions/browser/extension_message_filter.cc ...
6 years, 4 months ago (2014-08-22 15:12:55 UTC) #3
not at google - send to devlin
lgtm
6 years, 4 months ago (2014-08-22 16:18:08 UTC) #4
kenrb
ipc lgtm -- I think you still need an OWNER for the renderer_host files though
6 years, 4 months ago (2014-08-22 17:26:00 UTC) #5
Xi Han
sky@chromium.org: Please review changes in -chrome/browser/renderer_host/chrome_extension_message_filter.h -chrome/browser/renderer_host/chrome_extension_message_filter.cc Thanks!
6 years, 4 months ago (2014-08-22 17:37:29 UTC) #6
Xi Han
guest_view_internal_custom_bindings.h(.cc) are used to send the ipc message ExtensionHostMsg_AttachGuest, and should be move to extensions ...
6 years, 4 months ago (2014-08-22 18:45:59 UTC) #7
Fady Samuel
https://codereview.chromium.org/497103002/diff/40001/extensions/renderer/guest_view_internal_custom_bindings.h File extensions/renderer/guest_view_internal_custom_bindings.h (right): https://codereview.chromium.org/497103002/diff/40001/extensions/renderer/guest_view_internal_custom_bindings.h#newcode6 extensions/renderer/guest_view_internal_custom_bindings.h:6: #define EXTENSIONS_RENDERER_GUEST_VIEW_INTERNAL_CUSTOM_BINDINGS_H_ Can we move this to extension/renderer/guest_view/*? Also, ...
6 years, 4 months ago (2014-08-22 18:49:06 UTC) #8
Xi Han
6 years, 4 months ago (2014-08-22 19:09:03 UTC) #9
Fady Samuel
https://codereview.chromium.org/497103002/diff/60001/chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc File chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc (right): https://codereview.chromium.org/497103002/diff/60001/chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc#newcode124 chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc:124: new extensions::GuestViewInternalCustomBindings(context))); Could we move this to extensions as ...
6 years, 4 months ago (2014-08-22 19:20:59 UTC) #10
Fady Samuel
https://codereview.chromium.org/497103002/diff/60001/chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc File chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc (right): https://codereview.chromium.org/497103002/diff/60001/chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc#newcode124 chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc:124: new extensions::GuestViewInternalCustomBindings(context))); On 2014/08/22 19:20:59, Fady Samuel wrote: > ...
6 years, 4 months ago (2014-08-22 19:23:38 UTC) #11
sky
chrome/browser/renderer_host/chrome_extension_message_filter.* LGTM
6 years, 4 months ago (2014-08-22 19:46:50 UTC) #12
Xi Han
PTAL. https://codereview.chromium.org/497103002/diff/60001/chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc File chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc (right): https://codereview.chromium.org/497103002/diff/60001/chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc#newcode124 chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc:124: new extensions::GuestViewInternalCustomBindings(context))); On 2014/08/22 19:20:59, Fady Samuel wrote: ...
6 years, 4 months ago (2014-08-22 20:47:36 UTC) #13
Fady Samuel
still lgtm
6 years, 4 months ago (2014-08-22 20:48:40 UTC) #14
Xi Han
The CQ bit was checked by hanxi@chromium.org
6 years, 4 months ago (2014-08-22 21:37:41 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hanxi@chromium.org/497103002/80001
6 years, 4 months ago (2014-08-22 21:41:33 UTC) #16
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 22:50:08 UTC) #17
Message was sent while issue was closed. 
Committed patchset #5 (80001) as 291542

Powered by Google App Engine
This is Rietveld 408576698