chrome/installer/util/delete_after_reboot_helper.cc - Issue 497083004: Change base/file_utils.h includes to base/files/file_utils.h in chrome/, part 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/delete_after_reboot_helper.cc

Issue 497083004: Change base/file_utils.h includes to base/files/file_utils.h in chrome/, part 2. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@file_util

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/installer/util/create_dir_work_item_unittest.cc ('k') | chrome/installer/util/delete_after_reboot_helper_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/installer/util/delete_after_reboot_helper.cc

diff --git a/chrome/installer/util/delete_after_reboot_helper.cc b/chrome/installer/util/delete_after_reboot_helper.cc

index fb7956ed2624e9db2a793058c3ac4e3ff168c66e..b298d6a21b7272bf5196a9405c26d67925392626 100644

--- a/chrome/installer/util/delete_after_reboot_helper.cc

+++ b/chrome/installer/util/delete_after_reboot_helper.cc

@@ -15,8 +15,8 @@

#include <string>

#include <vector>

-#include "base/file_util.h"

#include "base/files/file_enumerator.h"

+#include "base/files/file_util.h"

#include "base/strings/string_util.h"

#include "base/win/registry.h"

@@ -81,10 +81,10 @@ bool ScheduleFileSystemEntityForDeletion(const base::FilePath& path) {

GENERIC_READ | GENERIC_WRITE, 0, NULL,

OPEN_EXISTING, 0, NULL);

if (file != INVALID_HANDLE_VALUE) {

- LOG(INFO) << " file not in use: " << path.value();

Lei Zhang 2014/08/23 02:02:31 presubmit complained, so I changed it and now you

+ VLOG(1) << " file not in use: " << path.value();

::CloseHandle(file);

} else {

- PLOG(INFO) << " file in use (or not found?): " << path.value();

+ PLOG(WARNING) << " file in use (or not found?): " << path.value();

}

#endif