Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Issue 497083004: Change base/file_utils.h includes to base/files/file_utils.h in chrome/, part 2. (Closed)

Created:
6 years, 4 months ago by Lei Zhang
Modified:
6 years, 3 months ago
Reviewers:
robertshield
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@file_util
Project:
chromium
Visibility:
Public.

Description

Change base/file_utils.h includes to base/files/file_utils.h in chrome/, part 2. Committed: https://crrev.com/d19a1692e6b582d8caf07e24c77e95b0e3355d0f Cr-Commit-Position: refs/heads/master@{#291609}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -116 lines) Patch
M chrome/browser/chrome_plugin_interactive_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/launcher_support/chrome_launcher_support.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/setup/archive_patch_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/setup/archive_patch_helper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/setup/install.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/setup/install_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/setup/install_worker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/setup/setup_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/setup/setup_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/setup/setup_util_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/setup/uninstall.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/test/alternate_version_generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/test/alternate_version_generator_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/test/upgrade_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/tools/validate_installation_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/chrome_browser_operations.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/conditional_work_item_list.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/copy_tree_work_item.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/copy_tree_work_item_unittest.cc View 1 2 chunks +49 lines, -47 lines 0 comments Download
M chrome/installer/util/create_dir_work_item.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/create_dir_work_item_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/delete_after_reboot_helper.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/installer/util/delete_after_reboot_helper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/delete_tree_work_item.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/delete_tree_work_item_unittest.cc View 1 2 chunks +22 lines, -21 lines 0 comments Download
M chrome/installer/util/duplicate_tree_detector.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/duplicate_tree_detector_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/eula_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/google_update_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/install_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/install_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/installer_state.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/installer_state_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/logging_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/logging_installer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/lzma_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/lzma_util_unittest.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/installer/util/master_preferences.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/master_preferences_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/move_tree_work_item.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/move_tree_work_item_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/self_cleaning_temp_dir.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/self_cleaning_temp_dir_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/shell_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/shell_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/work_item_list_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Lei Zhang
All the files where the diff is +1/-1 should be trivial. https://codereview.chromium.org/497083004/diff/1/chrome/installer/util/delete_after_reboot_helper.cc File chrome/installer/util/delete_after_reboot_helper.cc (left): ...
6 years, 4 months ago (2014-08-23 02:02:32 UTC) #1
robertshield
The CQ bit was checked by robertshield@chromium.org
6 years, 4 months ago (2014-08-23 12:01:26 UTC) #2
robertshield
lgtm
6 years, 4 months ago (2014-08-23 12:01:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/497083004/20001
6 years, 4 months ago (2014-08-23 12:03:11 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (20001) as 4ce52a985b0f323f35facb94c9415c0bd0bec4e5
6 years, 4 months ago (2014-08-23 22:19:01 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:32:08 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d19a1692e6b582d8caf07e24c77e95b0e3355d0f
Cr-Commit-Position: refs/heads/master@{#291609}

Powered by Google App Engine
This is Rietveld 408576698