Issue 497013003: [fsp] Fix aborting in File Stream Writer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 497013003: [fsp] Fix aborting in File Stream Writer. (Closed)

Created:
6 years, 4 months ago by mtomasz

Modified:
6 years, 3 months ago

Reviewers:
hirono

CC:
chromium-reviews, nkostylev+watch_chromium.org, tzik, nhiroki, oshima+watch_chromium.org, stevenjb+watch_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[fsp] Fix aborting in File Stream Writer. The abort callback should be set to the last abortable operation. TEST=browser_tests: *FileSystemProvider*WriteFile* BUG=405821 Committed: https://crrev.com/5d93ad15ef67612f4dc8c34e97166bd0708a166a Cr-Commit-Position: refs/heads/master@{#291656}

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	chrome/browser/chromeos/file_system_provider/fileapi/file_stream_writer.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/497013003/1

6 years, 4 months ago (2014-08-25 07:46:04 UTC) #4

commit-bot: I haz the power

Committed patchset #1 (1) as 6854b6184a5355720f34df66ad729e8c583464d3

6 years, 4 months ago (2014-08-25 11:08:48 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 02:33:35 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/5d93ad15ef67612f4dc8c34e97166bd0708a166a
Cr-Commit-Position: refs/heads/master@{#291656}

Expand Messages | Collapse Messages