ServiceWorker: Stop sending the SetVersionAttributes message from SWProviderHost

content/browser/service_worker/service_worker_provider_host.h

Index: content/browser/service_worker/service_worker_provider_host.h
diff --git a/content/browser/service_worker/service_worker_provider_host.h b/content/browser/service_worker/service_worker_provider_host.h
index 8d20be0d1ee2987753e881b8faebff79beb843a7..372ecd3b02f0c81ba90c71ee399d16ada9feff3b 100644
--- a/content/browser/service_worker/service_worker_provider_host.h
+++ b/content/browser/service_worker/service_worker_provider_host.h
@@ -122,23 +122,17 @@ class CONTENT_EXPORT ServiceWorkerProviderHost
   virtual void OnRegistrationFailed(
       ServiceWorkerRegistration* registration) OVERRIDE;
 
-  // Sets the corresponding version field to the given version or if the given
-  // version is NULL, clears the field.
-  void SetVersionAttributes(
+  // Adds this provider host to the potential controllee list of the given
+  // versions and removes from one of the previous versions.

[falken, 2014/08/22 09:04:36]

I think "and removes it from the previous versions" ?

"one of" seems wrong; the function removes from all of the previous versions.

[nhiroki, 2014/08/22 10:35:17]

Done.

+  void UpdatePotentialControllees(
       ServiceWorkerVersion* installing_version,
       ServiceWorkerVersion* waiting_version,
       ServiceWorkerVersion* active_version);
-  void SetVersionAttributesInternal(
-      ServiceWorkerVersion* version,
-      scoped_refptr<ServiceWorkerVersion>* data_member);
 
   // Sets the controller version field to |version| or if |version| is NULL,
   // clears the field.
   void SetControllerVersionAttribute(ServiceWorkerVersion* version);
 
-  // Clears all version fields.
-  void ClearVersionAttributes();
-
   // Creates a ServiceWorkerHandle to retain |version| and returns a
   // ServiceWorkerInfo with the handle ID to pass to the provider. The
   // provider is responsible for releasing the handle.