Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1038)

Issue 496983002: ServiceWorker: Stop sending the SetVersionAttributes message from SWProviderHost (Closed)

Created:
6 years, 4 months ago by nhiroki
Modified:
6 years, 3 months ago
Reviewers:
falken, michaeln
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Stop sending the SetVersionAttributes message from SWProviderHost SWProviderHost had sent the SetVersionAttributes message to set version attribtues of SWContainer (eg. navigator.serviceWorker.installing), but these attributes were moved into SWRegistration and the message is now sent from SWRegistrationHandle. BUG=404982 TEST=content_unittests --gtest_filter=ServiceWorker* TEST=run_webkit_tests.py --debug http/tests/serviceworker Committed: https://crrev.com/f481929280d7362d77e6fb336ccea03bbeee42bd Cr-Commit-Position: refs/heads/master@{#292110}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : fix comment #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -67 lines) Patch
M content/browser/service_worker/service_worker_provider_host.h View 1 2 1 chunk +3 lines, -9 lines 0 comments Download
M content/browser/service_worker/service_worker_provider_host.cc View 1 2 5 chunks +35 lines, -58 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
nhiroki
Ptal, thanks!
6 years, 4 months ago (2014-08-22 07:26:02 UTC) #1
falken
lgtm https://codereview.chromium.org/496983002/diff/20001/content/browser/service_worker/service_worker_provider_host.h File content/browser/service_worker/service_worker_provider_host.h (right): https://codereview.chromium.org/496983002/diff/20001/content/browser/service_worker/service_worker_provider_host.h#newcode126 content/browser/service_worker/service_worker_provider_host.h:126: // versions and removes from one of the ...
6 years, 4 months ago (2014-08-22 09:04:36 UTC) #2
nhiroki
Thanks! https://codereview.chromium.org/496983002/diff/20001/content/browser/service_worker/service_worker_provider_host.h File content/browser/service_worker/service_worker_provider_host.h (right): https://codereview.chromium.org/496983002/diff/20001/content/browser/service_worker/service_worker_provider_host.h#newcode126 content/browser/service_worker/service_worker_provider_host.h:126: // versions and removes from one of the ...
6 years, 4 months ago (2014-08-22 10:35:18 UTC) #3
michaeln
lgtm2
6 years, 4 months ago (2014-08-25 21:42:51 UTC) #4
nhiroki
The CQ bit was checked by nhiroki@chromium.org
6 years, 3 months ago (2014-08-27 05:46:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/496983002/60001
6 years, 3 months ago (2014-08-27 05:46:11 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (60001) as d94a7a95235f234c1b2f4fa6920969d561c69447
6 years, 3 months ago (2014-08-27 06:58:02 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:50:14 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f481929280d7362d77e6fb336ccea03bbeee42bd
Cr-Commit-Position: refs/heads/master@{#292110}

Powered by Google App Engine
This is Rietveld 408576698