Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1044)

Unified Diff: chrome/browser/extensions/api/declarative/rules_registry_service.h

Issue 49693003: Refactor RulesRegistryWithCache to RulesRegistry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Tests mostly work Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/declarative/rules_registry_service.h
diff --git a/chrome/browser/extensions/api/declarative/rules_registry_service.h b/chrome/browser/extensions/api/declarative/rules_registry_service.h
index ee8833e3d49c85290740a4eb7b6de5484dc3de50..f4816da9d01e89013f41209a805cfcfbd9e06a55 100644
--- a/chrome/browser/extensions/api/declarative/rules_registry_service.h
+++ b/chrome/browser/extensions/api/declarative/rules_registry_service.h
@@ -12,7 +12,7 @@
#include "base/callback_forward.h"
#include "base/memory/ref_counted.h"
#include "base/memory/scoped_vector.h"
-#include "chrome/browser/extensions/api/declarative/rules_registry_with_cache.h"
+#include "chrome/browser/extensions/api/declarative/rules_registry.h"
#include "chrome/browser/extensions/api/profile_keyed_api_factory.h"
#include "chrome/browser/profiles/profile.h"
#include "content/public/browser/notification_observer.h"
@@ -73,7 +73,8 @@ class RulesRegistryService : public ProfileKeyedAPI,
friend class ProfileKeyedAPIFactory<RulesRegistryService>;
// Maps event names to RuleRegistries that handle these events.
- typedef std::map<std::string, scoped_refptr<RulesRegistry> > RulesRegistryMap;
+ typedef std::map<std::string, scoped_refptr<RulesRegistry> >
+ RulesRegistryMap;
vabr (Chromium) 2013/10/29 16:05:54 nit: This line seems to actually fit on one line.
// Notifies all RulesRegistries that |extension_id| was unloaded.
// It is not guaranteed that this notification is processed synchronously.
@@ -95,7 +96,7 @@ class RulesRegistryService : public ProfileKeyedAPI,
RulesRegistryMap rule_registries_;
// We own the parts of the registries which need to run on the UI thread.
- ScopedVector<RulesRegistryWithCache::RuleStorageOnUI> ui_parts_of_registries_;
+ ScopedVector<RulesCacheDelegate> ui_parts_of_registries_;
// Weak pointer into rule_registries_ to make it easier to handle content rule
// conditions.

Powered by Google App Engine
This is Rietveld 408576698