Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1640)

Unified Diff: chrome/browser/extensions/api/declarative/initializing_rules_registry.h

Issue 49693003: Refactor RulesRegistryWithCache to RulesRegistry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed nits Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/api/declarative/initializing_rules_registry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/declarative/initializing_rules_registry.h
diff --git a/chrome/browser/extensions/api/declarative/initializing_rules_registry.h b/chrome/browser/extensions/api/declarative/initializing_rules_registry.h
deleted file mode 100644
index 4a4fd3602ac527e580f3a0f637fd0ad03130b5af..0000000000000000000000000000000000000000
--- a/chrome/browser/extensions/api/declarative/initializing_rules_registry.h
+++ /dev/null
@@ -1,91 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef CHROME_BROWSER_EXTENSIONS_API_DECLARATIVE_INITIALIZING_RULES_REGISTRY_H__
-#define CHROME_BROWSER_EXTENSIONS_API_DECLARATIVE_INITIALIZING_RULES_REGISTRY_H__
-
-#include "chrome/browser/extensions/api/declarative/rules_registry.h"
-
-#include <map>
-#include <set>
-
-#include "base/compiler_specific.h"
-#include "base/memory/ref_counted.h"
-
-namespace extensions {
-
-// Wrapper class for RulesRegistry objects that takes care that all optional
-// fields of rules are filled with valid values.
-class InitializingRulesRegistry : public RulesRegistry {
- public:
- enum Defaults { DEFAULT_PRIORITY = 100 };
-
- explicit InitializingRulesRegistry(scoped_refptr<RulesRegistry> delegate);
-
- // Implementation for RulesRegistry:
- virtual std::string AddRules(
- const std::string& extension_id,
- const std::vector<linked_ptr<RulesRegistry::Rule> >& rules) OVERRIDE;
- virtual std::string RemoveRules(
- const std::string& extension_id,
- const std::vector<std::string>& rule_identifiers) OVERRIDE;
- virtual std::string RemoveAllRules(
- const std::string& extension_id) OVERRIDE;
- virtual std::string GetRules(
- const std::string& extension_id,
- const std::vector<std::string>& rule_identifiers,
- std::vector<linked_ptr<RulesRegistry::Rule> >* out) OVERRIDE;
- virtual std::string GetAllRules(
- const std::string& extension_id,
- std::vector<linked_ptr<RulesRegistry::Rule> >* out) OVERRIDE;
- virtual void OnExtensionUnloaded(const std::string& extension_id) OVERRIDE;
-
- // Returns the number of entries in used_rule_identifiers_ for leak detection.
- // Every ExtensionId counts as one entry, even if it contains no rules.
- size_t GetNumberOfUsedRuleIdentifiersForTesting() const;
-
- private:
- virtual ~InitializingRulesRegistry();
-
- // Returns whether any existing rule is registered with identifier |rule_id|
- // for extension |extension_id|.
- bool IsUniqueId(const std::string& extension_id,
- const std::string& rule_id) const;
-
- // Creates an ID that is unique within the scope of|extension_id|.
- std::string GenerateUniqueId(const std::string& extension_id);
-
- // Verifies that all |rules| have unique IDs or initializes them with
- // unique IDs if they don't have one. In case of duplicate IDs, this function
- // returns a non-empty error message.
- std::string CheckAndFillInOptionalRules(
- const std::string& extension_id,
- const std::vector<linked_ptr<RulesRegistry::Rule> >& rules);
-
- // Initializes the priority fields in case they have not been set.
- void FillInOptionalPriorities(
- const std::vector<linked_ptr<RulesRegistry::Rule> >& rules);
-
- // Removes all |identifiers| of |extension_id| from |used_rule_identifiers_|.
- void RemoveUsedRuleIdentifiers(const std::string& extension_id,
- const std::vector<std::string>& identifiers);
-
- // Same as RemoveUsedRuleIdentifiers but operates on all rules of
- // |extension_id|.
- void RemoveAllUsedRuleIdentifiers(const std::string& extension_id);
-
- scoped_refptr<RulesRegistry> delegate_;
-
- typedef std::string ExtensionId;
- typedef std::string RuleIdentifier;
- typedef std::map<ExtensionId, std::set<RuleIdentifier> > RuleIdentifiersMap;
- RuleIdentifiersMap used_rule_identifiers_;
- int last_generated_rule_identifier_id_;
-
- DISALLOW_COPY_AND_ASSIGN(InitializingRulesRegistry);
-};
-
-} // namespace extensions
-
-#endif // CHROME_BROWSER_EXTENSIONS_API_DECLARATIVE_INITIALIZING_RULES_REGISTRY_H__
« no previous file with comments | « no previous file | chrome/browser/extensions/api/declarative/initializing_rules_registry.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698