Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 49693002: Use SkPathRef gen id for SkPath::getGenerationID (Closed)

Created:
7 years, 1 month ago by bsalomon
Modified:
7 years, 1 month ago
Reviewers:
mtklein, robertphillips
CC:
skia-review_googlegroups.com, djsollen
Visibility:
Public.

Description

Use SkPathRef gen id for SkPath::getGenerationID Committed: http://code.google.com/p/skia/source/detail?r=12029

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 5

Patch Set 3 : Address mtklein's comments. #

Patch Set 4 : balance the parens #

Patch Set 5 : Unit test fix #

Patch Set 6 : one more test #

Total comments: 4

Patch Set 7 : Address Mike's comments #

Patch Set 8 : upload again, rietveld diff failed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -67 lines) Patch
M include/core/SkPath.h View 1 6 chunks +12 lines, -14 lines 0 comments Download
M include/core/SkPathRef.h View 1 2 3 chunks +8 lines, -9 lines 0 comments Download
M src/core/SkPath.cpp View 1 2 3 15 chunks +11 lines, -32 lines 0 comments Download
M src/core/SkPathRef.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M tests/PathTest.cpp View 1 2 3 4 5 6 3 chunks +61 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
bsalomon
7 years, 1 month ago (2013-10-28 19:57:10 UTC) #1
mtklein
https://codereview.chromium.org/49693002/diff/30001/include/core/SkPathRef.h File include/core/SkPathRef.h (right): https://codereview.chromium.org/49693002/diff/30001/include/core/SkPathRef.h#newcode233 include/core/SkPathRef.h:233: * contents but different genIDs. Zero is reserved and ...
7 years, 1 month ago (2013-10-29 20:38:36 UTC) #2
bsalomon
https://codereview.chromium.org/49693002/diff/30001/include/core/SkPathRef.h File include/core/SkPathRef.h (right): https://codereview.chromium.org/49693002/diff/30001/include/core/SkPathRef.h#newcode233 include/core/SkPathRef.h:233: * contents but different genIDs. Zero is reserved and ...
7 years, 1 month ago (2013-10-29 20:45:03 UTC) #3
mtklein
On 2013/10/29 20:45:03, bsalomon wrote: > https://codereview.chromium.org/49693002/diff/30001/include/core/SkPathRef.h > File include/core/SkPathRef.h (right): > > https://codereview.chromium.org/49693002/diff/30001/include/core/SkPathRef.h#newcode233 > ...
7 years, 1 month ago (2013-10-29 20:47:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/49693002/130001
7 years, 1 month ago (2013-10-29 20:49:55 UTC) #5
commit-bot: I haz the power
Change committed as 12010
7 years, 1 month ago (2013-10-29 21:34:58 UTC) #6
robertphillips
reverted in r12012 due to Android failures on PathTest: FAILED: ../../../tests/PathTest.cpp:150: copy.getGenerationID() > copyID FAILED: ...
7 years, 1 month ago (2013-10-29 22:47:39 UTC) #7
bsalomon
On 2013/10/29 22:47:39, robertphillips wrote: > reverted in r12012 due to Android failures on PathTest: ...
7 years, 1 month ago (2013-10-30 13:06:45 UTC) #8
bsalomon
mtklein@, can you have a look at PathTest.cpp?
7 years, 1 month ago (2013-10-30 15:49:53 UTC) #9
mtklein
lgtm with suggestions https://codereview.chromium.org/49693002/diff/260001/tests/PathTest.cpp File tests/PathTest.cpp (left): https://codereview.chromium.org/49693002/diff/260001/tests/PathTest.cpp#oldcode153 tests/PathTest.cpp:153: // Test reset. Increment generation ID, ...
7 years, 1 month ago (2013-10-30 15:59:09 UTC) #10
bsalomon
https://codereview.chromium.org/49693002/diff/260001/tests/PathTest.cpp File tests/PathTest.cpp (left): https://codereview.chromium.org/49693002/diff/260001/tests/PathTest.cpp#oldcode153 tests/PathTest.cpp:153: // Test reset. Increment generation ID, don't touch source ...
7 years, 1 month ago (2013-10-30 17:39:07 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/49693002/320001
7 years, 1 month ago (2013-10-30 17:39:23 UTC) #12
commit-bot: I haz the power
7 years, 1 month ago (2013-10-30 18:57:59 UTC) #13
Message was sent while issue was closed.
Change committed as 12029

Powered by Google App Engine
This is Rietveld 408576698